190729 - remove some dead code from xbl service

Status: RESOLVED FIXED

(Core :: XBL, defect, P3)

Description

[Alec Flett]

I just found some dead code, and some methods that don't need to be on
nsIXBLService that are used internally but don't need to be virtual, as well as
some method private to nsXBLService that are virtual but don't need to be.

patch forthcoming

Comment 1

[Alec Flett]

Attachment: remove the dead/excess code

and here's the patch

Comment 2

[Alec Flett]

Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code

Reviews? this is easy stuff, just code removal/rearrangement

Comment 3

[jag (Peter Annema)]

Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code

Looks okay, but get hyatt to r=/moa=.

Comment 4

[Alec Flett]

nominating some of my footprint/perf bugs for topembed

Comment 5

[Alec Flett]

Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code

no response from hyatt, over to bryner.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code

FetchSyncXMLDocument() _is_ actually used by Chimera, but it could just as
easily use the SyncLoadDOMService directly (and this won't affect active
Chimera development, yet).

Comment 7

[Alec Flett]

good to know. I'm going to be revamping the sync load stuff during 1.4alpha
anyhow, so I'll go ahead and remove this. thanks.

Comment 8

[Alec Flett]

fix is in.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 171032 has been marked as a duplicate of this bug. ***