Closed
Bug 190729
Opened 22 years ago
Closed 22 years ago
remove some dead code from xbl service
Categories
(Core :: XBL, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: alecf, Assigned: alecf)
References
Details
(Keywords: memory-footprint, topembed+, Whiteboard: fix in hand)
Attachments
(1 file)
|
7.68 KB,
patch
|
bryner
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
I just found some dead code, and some methods that don't need to be on
nsIXBLService that are used internally but don't need to be virtual, as well as
some method private to nsXBLService that are virtual but don't need to be.
patch forthcoming
|
Assignee | |
Comment 1•22 years ago
|
||
and here's the patch
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code
Reviews? this is easy stuff, just code removal/rearrangement
Attachment #112704 -
Flags: superreview?(jaggernaut)
Attachment #112704 -
Flags: review?(hyatt)
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: fix in hand
Target Milestone: --- → mozilla1.4alpha
|
||
Comment 3•22 years ago
|
||
Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code
Looks okay, but get hyatt to r=/moa=.
Attachment #112704 -
Flags: superreview?(jaggernaut) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
nominating some of my footprint/perf bugs for topembed
Keywords: topembed
|
||
Updated•22 years ago
|
|
|
Assignee | |
Comment 5•22 years ago
|
||
Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code
no response from hyatt, over to bryner.
Attachment #112704 -
Flags: review?(hyatt) → review?(bryner)
|
||
Comment 6•22 years ago
|
||
Comment on attachment 112704 [details] [diff] [review]
remove the dead/excess code
FetchSyncXMLDocument() _is_ actually used by Chimera, but it could just as
easily use the SyncLoadDOMService directly (and this won't affect active
Chimera development, yet).
Attachment #112704 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 7•22 years ago
|
||
good to know. I'm going to be revamping the sync load stuff during 1.4alpha
anyhow, so I'll go ahead and remove this. thanks.
|
|
Assignee | |
Comment 8•22 years ago
|
||
fix is in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 171032 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•