1907302 - Add optional padding and direct write changes to Uint8Array to/from base64 proposal

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[André Bargull [:anba]]

Implement the changes from

• https://github.com/tc39/proposal-arraybuffer-base64/pull/58
• https://github.com/tc39/proposal-arraybuffer-base64/pull/60

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1907302 - Part 1: Add option to omit padding in Uint8Array.prototype.toBase64. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-arraybuffer-base64/pull/60

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1907302 - Part 2: Write data up until error in Uint8Array.prototype.setFrom{Base64,Hex} methods. r=#spidermonkey-reviewers!

Change FromHex and FromBase64 to accept a templated Sink parameter, which
either appends to a ByteVector or directly into the target TypedArrayObject.
Uint8Array.prototype.setFrom{Base64,Hex} now no longer have to allocate
temporary space when processing the input string.

Changes from:
https://github.com/tc39/proposal-arraybuffer-base64/pull/58

Depends on D216279

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe345577ce8d
Part 1: Add option to omit padding in Uint8Array.prototype.toBase64. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/67f24633fa04
Part 2: Write data up until error in Uint8Array.prototype.setFrom{Base64,Hex} methods. r=spidermonkey-reviewers,dminor

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fe345577ce8d
https://hg.mozilla.org/mozilla-central/rev/67f24633fa04