1907320 - Allow style sharing on elements that specify transitions / animations.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This is a big performance improvement, see https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=073887c4b0647a4d64302b799a498adcf3f344ba&originalSignature=4569240&newSignature=4569240&framework=13&application=firefox&originalRevision=c9c19b8d563f42efe38b1746e2025521e5702c93&page=1&showOnlyConfident=1 and co.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1907320 - Allow sharing styles that specify transitions / animations. r=#style

Most styles that specify transitions don't actually have a transition
running at the very same time, and we can check for that in the cache
already.

We need to avoid reusing-by-rule-node for @starting-style rules, but
that's fine because that's effectively what already happened before this
change, due to the check we're removing (we only resolve @starting-style
when we're about to maybe-start a transition).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8b2df49bf0
Allow sharing styles that specify transitions / animations. r=firefox-style-system-reviewers,layout-reviewers,boris

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/cf8b2df49bf0

Comment 4

[Alex Finder]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8b2df49bf0
Allow sharing styles that specify transitions / animations.
r=firefox-style-system-reviewers,layout-reviewers,boris

Perfherder has detected a browsertime performance change from push cf8b2df49bf0901b08109fe6f4d5ba4c178c1a0f.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
5%	speedometer React-TodoMVC/CompletingAllItems/Async	linux1804-64-shippable-qr	fission webrender	3.08 -> 2.92	Before/After
3%	speedometer3 TodoMVC-Svelte-Complex-DOM/Adding100Items/Async	macosx1400-64-shippable-qr	fission webrender	4.07 -> 3.93	Before/After
3%	speedometer Flight-TodoMVC/CompletingAllItems/Async	linux1804-64-shippable-qr	fission webrender	4.22 -> 4.08	Before/After
3%	speedometer3 TodoMVC-Preact-Complex-DOM/total	macosx1400-64-shippable-qr	fission webrender	11.63 -> 11.34	Before/After
2%	speedometer Inferno-TodoMVC/Adding100Items	windows11-64-shippable-qr	fission webrender	9.72 -> 9.52	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1205

For more information on performance sheriffing please see our FAQ.