1907414 - [Wayland] Winger popup no longer renders extension content (regression)

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Asif Youssuff]

Attachment: winger-bad.webm

Noticed awhile ago that when Winger https://addons.mozilla.org/en-US/firefox/addon/winger/ is called from a maximized window on my Linux machine that the extension content no longer appears after a certain build.

13:14.54 INFO: Narrowed integration regression window from [ccaccfe2, 1dc1bad3] (3 builds) to [ccaccfe2, 63cb54db] (2 builds) (~1 steps left)
13:14.54 INFO: No more integration revisions, bisection finished.
13:14.54 INFO: Last good revision: ccaccfe2cb77380846b2d6c5ab5cc3da4ab5cb33
13:14.54 INFO: First bad revision: 63cb54db7879e0d226fb023288e30a0e22ca204f
13:14.54 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ccaccfe2cb77380846b2d6c5ab5cc3da4ab5cb33&tochange=63cb54db7879e0d226fb023288e30a0e22ca204f

Steps to reproduce:

1. Have Winger installed
2. Maximize Firefox in GNOME
3. use keyboard shortcut to open winger

What happens:

The extension very briefly shows the content, but quickly is replaced by a gray background. The extension continues to work (I can move windows around using the keyboard shortcuts).

Video can be seen of what happens.

Comment 1

[Asif Youssuff]

Attachment: winger-good.webm

This video shows how this used to work.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1875369

:stransky, since you are the author of the regressor, bug 1875369, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Asif Youssuff]

Attachment: about:support

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Can you please run with MOZ_LOG="WidgetPopup:5 WidgetWayland:5" env variable and attach the log here? On terminal as:
MOZ_LOG="WidgetPopup:5 WidgetWayland:5" firefox > log.txt 2>&1
Thanks.

Comment 5

[Asif Youssuff]

Attachment: log from running firefox and opening winger twice

Martin,

The log is attached. I opened the popup twice and exited Firefox afterwards.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Please try to run without > log.txt 2>&1 (i.e. redirection to file) and try to mark where the log ends when popup is shown but it doesn't have any content.
Thanks.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Looks like we're missing OnExposeEvent() after compositor resume. But I wonder why we don't paint on VSync / refresh driver events.

<< We're getting expose but we quit due to missing wl_surface

[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]: nsWindow::OnExposeEvent GdkWindow [7fa4c8dd95c0] XID [0x0]
[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]: quit, !moz_container_wayland_can_draw()

<< We can paint now but we don't do it.

[Parent 4182553: Main Thread]: D/WidgetWayland moz_container_wayland_frame_callback_handler [7fa2e21d0b00] frame_callback_handler 7fa33ac1a3a0 ready_to_draw 0 (set to true) initial_draw callback 2
[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]:   moz_container_wayland_add_or_fire_initial_draw_callback ConfigureCompositor
[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]: nsWindow::ResumeCompositorImpl()
[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]: GtkCompositorWidget::SetRenderingSurface() [7fa2e21d0b00]
[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]:   configure widget 7fa2e21d0b00

<< No expose after nsWindow::ResumeCompositorImpl() but nsWindow::Destroy() is called (the popup is closed?)

[Parent 4182553: Main Thread]: D/WidgetPopup [7fa2e21d0b00]: nsWindow::Destroy

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Please download, extract and run this build with a new profile and check if you still see the problem:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WJwm9AxqTpmayemSAZqRBA/runs/0/artifacts/public/build/target.tar.bz2
Thanks.

Comment 9

[Asif Youssuff]

Martin, I downloaded and ran the build you asked me to run and it seems to work fine with a new profile. Using that build with my existing profile shows the same problem, however.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Asif Youssuff from comment #9)

Martin, I downloaded and ran the build you asked me to run and it seems to work fine with a new profile. Using that build with my existing profile shows the same problem, however.

Can you please try your recent (broken) firefox with a new profile?
Thanks.

Comment 11

[Asif Youssuff]

This has been working for me in Nightlies for a while now. Do we want to bother finding what fixed it, or should we close as WFM?

Comment 12

[Martin Stránský [:stransky] (ni? me)]

WFM is okay for me, Thanks.