1907419 - Home and newtab compact topsites card hover padding

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Attachment: image(28).png

If you hover over a topsite with browser.newtabpage.activity-stream.discoverystream.thumbsUpDown.searchTopsitesCompact set to true, there is a bit of padding work that could be done to improve it.

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1907419 - Adjust top sites hover padding spacing for thumbs up/down compact view r?#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a52c0232e3cb
Adjust top sites hover padding spacing for thumbs up/down compact view r=home-newtab-reviewers,thecount

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a52c0232e3cb

Comment 4

[Maxx Crawford [:maxx]]

Attachment: Bug 1907419 - Adjust top sites hover padding spacing for thumbs up/down compact view r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D216343

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: There shouldn't be any impact. It will only apply to experiment participants in the treatment branch of the Thumbs up/down topic selection experiment. This change/pref is off by default.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D216343
• Risk associated with taking this patch: Low
• Explanation of risk level: This is a CSS only fix, and only applies to a pref that will be flipped on by Experimenter
• String changes made/needed: No
• Is Android affected?: no

Comment 6

[Maxx Crawford [:maxx]]

[Tracking Requested - why for this release]: It's requested so that we can begin an experiment around thumbs up/down UI in 128.

Note: This is a CSS/design only fix.

Comment 7

[Peter Magyari (Desktop QA)]

I have verified the fix on Nightly 130.0a1 (20240716214815) the hover-padding spacing has been adjusted.
I will be back to verify it on Beta as well, once it gets uplifted.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/207a1cc78765

Comment 9

[Peter Magyari (Desktop QA)]

Verified fixed using Beta 129.0b6 (20240717201022) on Windows 10, MacOS 14 and Ubuntu 24.04.