Closed Bug 1907434 Opened 5 months ago Closed 4 months ago

Update desktop's Fakespot suggestion integration with the Rust component

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Once the Fakespot Rust changes are vendored into m-c, we'll need to update our Fakespot browser and xpcshell tests so that they use the mock remote settings server and the real Fakespot feature in the Rust component. There are some TODOs in both files.

We should resurrect some of the test tasks from my original diff in https://phabricator.services.mozilla.com/D215273?id=884095 plus the ability to set the RS collection in QuickSuggestTestUtils since Fakespot suggestions are in their own collection and not the usual quicksuggest collection.

Assignee: nobody → adw
Status: NEW → ASSIGNED

Morphing this to be about integrating our overall implementation with the Fakespot Rust changes since there's more than tests.

Summary: Update Fakespot tests once the Rust changes are vendored into mozilla-central → Update desktop's Fakespot suggestion integration with the Rust component
Whiteboard: [sng]

The Fakespot Rust changes haven't been vendored yet so this can't land until
then. To test it in the meantime, you can do a local vendor of the latest
application-services.

Depends on D216488, D216367

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/138cc2fe6254 Update desktop's Fakespot suggestion integration with the Rust component. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: