Update desktop's Fakespot suggestion integration with the Rust component
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox130 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
Once the Fakespot Rust changes are vendored into m-c, we'll need to update our Fakespot browser and xpcshell tests so that they use the mock remote settings server and the real Fakespot feature in the Rust component. There are some TODOs in both files.
Assignee | ||
Comment 1•5 months ago
•
|
||
We should resurrect some of the test tasks from my original diff in https://phabricator.services.mozilla.com/D215273?id=884095 plus the ability to set the RS collection in QuickSuggestTestUtils since Fakespot suggestions are in their own collection and not the usual quicksuggest collection.
Assignee | ||
Comment 2•5 months ago
|
||
Morphing this to be about integrating our overall implementation with the Fakespot Rust changes since there's more than tests.
Assignee | ||
Comment 3•5 months ago
|
||
The Fakespot Rust changes haven't been vendored yet so this can't land until
then. To test it in the meantime, you can do a local vendor of the latest
application-services.
Depends on D216488, D216367
Comment 5•4 months ago
|
||
bugherder |
Description
•