1907460 - Disable overflow/underflow events in release

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P3)

Description

[Gregory Pappas [:gregp]]

Specifically, disable these these prefs:

• layout.overflow-underflow.content.enabled
• layout.overflow-underflow.content.enabled_in_addons

Rob's analysis in bug 1897595 comment 25 shows that usage of these events in addons is negligible, so it should be safe to to toggle both prefs in the same release.

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1907460 - Disable overflow/underflow events in release

Comment 2

[Rob Wu [:robwu]]

The patch has been approved but should land in 3 weeks, when Nightly is bumped to 131. This deprecation matches what had been documented before at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/128#changes_for_add-on_developers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:gregp, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

See comment 2.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aef973f394fd
Disable overflow/underflow events in release r=emilio,extension-reviewers,robwu

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aef973f394fd

Comment 7

[Sebastian Zartner [:sebo]]

I think the removal of these two events should be documented, even when they are non-standard, so I've added the dev-doc-needed flag.

Sebastian

Comment 8

[:Gijs (he/him)]

Do we still support these events in chrome / system-privileged docs? Is there a follow-up to unship it there, too? (cf. https://searchfox.org/mozilla-central/rev/b1b87f95ecea00828298d1b3cd3d8718f9fcc3fc/browser/components/tabbrowser/content/tabs.js#1261 - but there are other instances as well)

Comment 9

[Gregory Pappas [:gregp]]

Do we still support these events in chrome / system-privileged docs?

Yes. https://searchfox.org/mozilla-central/rev/b1b87f95ecea00828298d1b3cd3d8718f9fcc3fc/layout/generic/ScrollContainerFrame.cpp#5921-5930

Is there a follow-up to unship it there, too?

Not at the moment.

Comment 10

[Gregory Pappas [:gregp]]

Emilio, should removing all usage of these events in chrome contexts be a goal?

Comment 11

[Emilio Cobos Álvarez [:emilio]]

I think it'd be worth it, yes. If only because they're not super-reliable.

Comment 12

[:Gijs (he/him)]

Thanks both, I filed bug 1913278.