Closed Bug 1907460 Opened 7 months ago Closed 7 months ago

Disable overflow/underflow events in release

Categories

(Core :: Layout: Scrolling and Overflow, task, P3)

task

Tracking

()

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: gregp, Assigned: gregp)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Specifically, disable these these prefs:

  • layout.overflow-underflow.content.enabled
  • layout.overflow-underflow.content.enabled_in_addons

Rob's analysis in bug 1897595 comment 25 shows that usage of these events in addons is negligible, so it should be safe to to toggle both prefs in the same release.

Assignee: nobody → gregp
Status: NEW → ASSIGNED

The patch has been approved but should land in 3 weeks, when Nightly is bumped to 131. This deprecation matches what had been documented before at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/128#changes_for_add-on_developers

Severity: -- → S3
Priority: -- → P3

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:gregp, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(gregp)
Flags: needinfo?(emilio)

See comment 2.

Flags: needinfo?(emilio)
Flags: needinfo?(gregp)
Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/aef973f394fd Disable overflow/underflow events in release r=emilio,extension-reviewers,robwu
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch

I think the removal of these two events should be documented, even when they are non-standard, so I've added the dev-doc-needed flag.

Sebastian

Keywords: dev-doc-needed
Regressions: 1912224

Do we still support these events in chrome / system-privileged docs? Is there a follow-up to unship it there, too? (cf. https://searchfox.org/mozilla-central/rev/b1b87f95ecea00828298d1b3cd3d8718f9fcc3fc/browser/components/tabbrowser/content/tabs.js#1261 - but there are other instances as well)

Flags: needinfo?(gregp)

Do we still support these events in chrome / system-privileged docs?

Yes. https://searchfox.org/mozilla-central/rev/b1b87f95ecea00828298d1b3cd3d8718f9fcc3fc/layout/generic/ScrollContainerFrame.cpp#5921-5930

Is there a follow-up to unship it there, too?

Not at the moment.

Flags: needinfo?(gregp)

Emilio, should removing all usage of these events in chrome contexts be a goal?

Flags: needinfo?(emilio)

I think it'd be worth it, yes. If only because they're not super-reliable.

Flags: needinfo?(emilio)
Blocks: 1913278

Thanks both, I filed bug 1913278.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: