1907560 - testTouchEventsOverride is async but doesn't perform any async operation nor return a Promise

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

see https://searchfox.org/mozilla-central/rev/1cc09ebc0b32f69fd30057582671b0811f2cb9c8/devtools/client/responsive/test/browser/head.js#644-660

async function testTouchEventsOverride(ui, expected) {
  const { document } = ui.toolWindow;
  const touchButton = document.getElementById("touch-simulation-button");

  const flag = gBrowser.selectedBrowser.browsingContext.touchEventsOverride;

  is(
    flag === "enabled",
    expected,
    `Touch events override should be ${expected ? "enabled" : "disabled"}`
  );
  is(
    touchButton.classList.contains("checked"),
    expected,
    `Touch simulation button should be ${expected ? "" : "in"}active.`
  );
}

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1907560 - [devtools] Turn testTouchEventsOverride into a sync function. r=#devtools-reviewers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83d224dffa04
[devtools] Turn testTouchEventsOverride into a sync function. r=devtools-reviewers,jdescottes.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/83d224dffa04