1907588 - Clean up add-on manager integration in search service related tests

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Now that bug 1906875 is done (well, almost landed), we have a lot of tests that can be cleaned up because we no longer need to initialise the add-on manager every time the search service starts - we only need it when a tests simulates a third party search engine WebExtension.

Hence we can do a lot of clean-up to avoid the calls to initialise it, and build the set-up that we do need into SearchTestUtils to automatically happen when we need it. This should avoid quite a bit of boiler-plate code.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1907588 - Remove now unused SearchTestUtils.installSystemSearchExtension. r?#search-reviewers!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1907588 - Change SearchTestUtils to be a class. r?#search-reviewers!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1907588 - In tests, only startup the Addon Manager when necessary, now that the search service doesn't require it all the time. r?#search-reviewers!

We no longer need to start the add-on manager before the search service starts, so init it only when it is needed for installing add-ons.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef56d77fe65f
Remove now unused SearchTestUtils.installSystemSearchExtension. r=search-reviewers,jteow
https://hg.mozilla.org/integration/autoland/rev/72a88ea1cb75
Change SearchTestUtils to be a class. r=search-reviewers,jteow
https://hg.mozilla.org/integration/autoland/rev/2e01f7bbae0b
In tests, only startup the Addon Manager when necessary, now that the search service doesn't require it all the time. r=search-reviewers,home-newtab-reviewers,jteow

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ef56d77fe65f
https://hg.mozilla.org/mozilla-central/rev/72a88ea1cb75
https://hg.mozilla.org/mozilla-central/rev/2e01f7bbae0b