Clean up add-on manager integration in search service related tests
Categories
(Firefox :: Search, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(3 files)
Now that bug 1906875 is done (well, almost landed), we have a lot of tests that can be cleaned up because we no longer need to initialise the add-on manager every time the search service starts - we only need it when a tests simulates a third party search engine WebExtension.
Hence we can do a lot of clean-up to avoid the calls to initialise it, and build the set-up that we do need into SearchTestUtils to automatically happen when we need it. This should avoid quite a bit of boiler-plate code.
|
||
Updated•2 months ago
|
|
Assignee | |
Comment 1•2 months ago
|
||
|
|
Assignee | |
Comment 2•2 months ago
|
||
|
|
Assignee | |
Comment 3•2 months ago
|
||
We no longer need to start the add-on manager before the search service starts, so init it only when it is needed for installing add-ons.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef56d77fe65f Remove now unused SearchTestUtils.installSystemSearchExtension. r=search-reviewers,jteow https://hg.mozilla.org/integration/autoland/rev/72a88ea1cb75 Change SearchTestUtils to be a class. r=search-reviewers,jteow https://hg.mozilla.org/integration/autoland/rev/2e01f7bbae0b In tests, only startup the Addon Manager when necessary, now that the search service doesn't require it all the time. r=search-reviewers,home-newtab-reviewers,jteow
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ef56d77fe65f
https://hg.mozilla.org/mozilla-central/rev/72a88ea1cb75
https://hg.mozilla.org/mozilla-central/rev/2e01f7bbae0b
Description
•