1907618 - [Toolbar Redesign] After dismissing the keyboard, the color of the bottom OS bar needs to match the toolbar color

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Aarjav [:aarjav]]

Attachment: 1000067567.mp4

Steps to reproduce

1. In the OS settings, the gesture bar navigation needs to be turned on[Screenshot attached].
2. Open a website
3. Select the URL bar
4. Dismiss the keyboard using the arrow on the keyboard or the OS bottom bar.

Expected behavior

• The keyboard needs to be properly dismissed, by the user being on the homepage and the OS bottom bar matching the colour of the toolbar.

Actual behavior

• The OS bottom bar colour doesn't match the toolbar color.

Device information

• Firefox version: Nightly
• Android device model: Pixel 6
• Android OS version: Latest

Any additional information?

Comment 1

[Aarjav [:aarjav]]

Attachment: Screenshot_20240712-114907.png

Comment 2

[Aarjav [:aarjav]]

Figma Link - https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=17640-291606&t=XwvFtnpcvRpQbby5-4

Comment 3

[[:skhan]]

Please note : This was prior to implementation of navigation bar. i.e it's in our release too.

Comment 4

[[:skhan]]

The might get fixed with Bug 1898059 's fix

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Good point!
Fixing bug 1898059 will avoid the issue when closing the keyboard with a back gesture
But there's another scenario remaining for this: when user swiped on the list of results - we're already hiding the keyboard and allow seeing/interacting with all results. We'd need now to update the OS navigation color.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1907618 - Use layer1 as the OS navigation bar background when searching r=#android-reviewers

This combines the requirements with the ones from bug 1907656 to ensure that when the
navbar is enabled:

• the status bar color is the same as the background of the edit toolbar
• the OS navigation bar is not translucent anymore
• the OS navigation bar color is the same as the background of the application's navbar

Comment 7

[Mike a [:mavduevskiy]]

(In reply to [:skhan] from comment #3)

Please note : This was prior to implementation of navigation bar. i.e it's in our release too.

Sarah had an excellent point. I see the but created with [toolbar redesign], but shouldn't we fix it generally, for both navbar on and off?

Comment 8

[Petru-Mugurel Lingurar [:petru]]

I don't see this as a bug in the current release - it has always function like so
Whereas it can be seen as a defect/improvement for the navbar which currently don't match the expected new design.

Comment 9

[Aarjav [:aarjav]]

It should be fixed for both navbar on and off. I am attaching a screenshot for the release version of Firefox and the issue can be seen there too.

Comment 10

[Aarjav [:aarjav]]

Attachment: Screenshot_20240903-151834.png

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efada75e1113
Use layer1 as the OS navigation bar background when searching r=android-reviewers,mavduevskiy

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/efada75e1113