1907772 - SVG textPath rendering is broken when letter-spacing is present

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Kew [:jfkthame]]

Since bug 1892262 landed, the testcase at https://bug1663380.bmoattachments.org/attachment.cgi?id=9174256, which should render the text "ABCDE ABCDE" spaced out along an arc, displays only the first character; the remaining text is missing.

Bug 1892262 added code to "trim" leading letter-spacing at start of line. I don't think we should apply this to text in SVG. In general it's unclear what would be the "start of line" as text elements (or indeed the individual characters within them) may be placed arbitrarily.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892262

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1907772 - Don't attempt to trim letter-spacing at start of line in textframes being used for SVG text. r=#layout

SVG text elements in general don't have a clearly-defined concept of "lines", so we can't
know where it would be appropriate to trim.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e75b0f8b9b42
Don't attempt to trim letter-spacing at start of line in textframes being used for SVG text. r=longsonr

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47126 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e75b0f8b9b42

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1907772 - Don't attempt to trim letter-spacing at start of line in textframes being used for SVG text.

SVG text elements in general don't have a clearly-defined concept of "lines", so we can't
know where it would be appropriate to trim.

Original Revision: https://phabricator.services.mozilla.com/D216506

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: SVG text-on-path broken if letter-spacing is present
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: one-line patch to avoid affecting SVG text
• String changes made/needed: none
• Is Android affected?: yes

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e3b99183dfce