Closed Bug 1907800 Opened 7 months ago Closed 7 months ago

[Menu Redesign] Support custom tab menu items

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: gl, Assigned: sanchaai)

References

Details

Attachments

(1 file)

Bug 1907800 - Support custom tab menu items. r=gl
48 bytes, text/x-phabricator-request
Details | Review

Custom tabs are able to supply a list of menu items that should be integrated in the custom tab menu. See CustomTabConfig.menuItems.

The task is to add the menuItems that are present in the CustomTabConfig to the custom tab menu. See the existing implementation at https://searchfox.org/mozilla-central/rev/8e1e3ac12373bd93cb56aa9dcf46ec6762a27384/mobile/android/android-components/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt#333

Assignee: nobody → giorga
Assignee: giorga → smathiyarasan
Status: NEW → ASSIGNED

Add the menuItems that are present in the CustomTabConfig to the custom tab menu.

Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43be5ff38c3b Support custom tab menu items. r=android-reviewers,petru

https://hg.mozilla.org/mozilla-central/rev/43be5ff38c3b

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: