1907883 - 187.99 - 2.01% speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/DeletingAllItems/Async / google-slides fcp + 417 more (Linux) regression on Wed July 10 2024

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Florin Bilt]

Perfherder has detected a browsertime performance change from push 8e03fe31e7d16e008b0f2b0b6723e697698e2cd5.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
188%	speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/DeletingAllItems/Async	linux1804-64-shippable-qr	fission webrender	3.04 -> 8.75	Before/After
153%	speedometer3 TodoMVC-jQuery/CompletingAllItems/Async	linux1804-64-shippable-qr	fission webrender	5.27 -> 13.33	Before/After
60%	speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/DeletingAllItems/total	linux1804-64-shippable-qr	fission webrender	24.92 -> 39.85	Before/After
57%	webaudio	linux1804-64-shippable-qr	fission webrender	94.62 -> 148.50	Before/After
55%	stylebench Structural pseudo classes/Removing leaf elements - 2/Sync	linux1804-64-shippable-qr	fission webrender	1.04 -> 1.60	Before/After
54%	stylebench Structural pseudo classes/Removing leaf elements - 0/Sync	linux1804-64-shippable-qr	fission webrender	1.01 -> 1.56	Before/After
54%	stylebench Sibling combinators/Removing leaf elements - 0/Sync	linux1804-64-shippable-qr	fission webrender	0.99 -> 1.52	Before/After
53%	stylebench Descendant and child combinators/Removing leaf elements - 3/Sync	linux1804-64-shippable-qr	fission webrender	0.95 -> 1.45	Before/After
52%	stylebench Structural pseudo classes/Removing leaf elements - 3/Sync	linux1804-64-shippable-qr	fission webrender	1.04 -> 1.58	Before/After
51%	stylebench Sibling combinators/Removing leaf elements - 3/Sync	linux1804-64-shippable-qr	fission webrender	0.99 -> 1.49	Before/After
...	...	...	...	...	...
3%	google-slides largestContentfulPaint	linux1804-64-shippable-qr	cold fission webrender	2,201.87 -> 2,257.54	Before/After
2%	google-slides ContentfulSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,776.82 -> 1,820.68	Before/After
2%	google-slides PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,537.56 -> 1,574.37	Before/After
2%	google-slides SpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,531.10 -> 1,567.08	Before/After
2%	google-slides fcp	linux1804-64-shippable-qr	cold fission webrender	973.65 -> 993.19	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
76%	speedometer3 TodoMVC-jQuery/DeletingAllItems/Async	linux1804-64-shippable-qr	fission webrender	7.13 -> 1.70	Before/After
20%	stylebench Structural pseudo classes/Mutating attributes - 3/Async	linux1804-64-shippable-qr	fission webrender	7.21 -> 5.75	Before/After
16%	stylebench Structural pseudo classes/Mutating attributes - 3	linux1804-64-shippable-qr	fission webrender	8.24 -> 6.89	Before/After
12%	addMar1 time_duration	linux1804-64-shippable-qr	fission webrender	6,446.31 -> 5,704.33	Before/After
11%	addkAR1 time_duration	linux1804-64-shippable-qr	fission webrender	47,589.76 -> 42,198.10	Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1137

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1896054

Comment 3

[:gerard-majax]

Turns out having ForkServer during the PGO profiling step seems to be the cause: we lack a lot of informations from profiling (missing PIDs profiles) so the PGO build is wrong

Comment 4

[:gerard-majax]

Attachment: Bug 1907883 - Enable ForkServer except for PGO, CCOV, ASAN, TSAN, MSAN and UBSAN r?#perftest-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d71e47a1911
Enable ForkServer except for PGO, CCOV, ASAN, TSAN, MSAN and UBSAN  r=perftest-reviewers,glandium,sparky

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5d71e47a1911

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gerard-majax, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.