1907901 - Text-Fragments: Split up non-html-documents.html test file

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Jan Jaeschke [:jjaschke]]

The tests in non-html-documents.html rely on the onload event being fired, which apparently does not happen in Gecko (see Bug 1905106). This makes the test timeout for JSON documents. Additionally, there are CI configurations which run so slow that other tests in that file may time out. Setting <meta name=timeout value=long> won't fix this properly because the JSON test is expected to time out.

To fix this, let's move the JSON test case into its own test file, mark it as expected: TIMEOUT, and add <meta name=timeout content=long> to the other test file to give them more time.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1907901 - Text Fragments: Separate json test case to let others pass. r=#dom-core!

The test to check if scrolling is allowed in non-html documents times out for JSON,
because it depends on the onload event, which Gecko is not firing for JSON (Bug 1905106).

Additionally, other test cases in that file can time out on CI as well.

With this patch, the JSON test case is separated into its own file and is expected to TIMEOUT. The other test cases get a longer timeout so that they pass in all configurations.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72e40f9471c4
Text Fragments: Separate json test case to let others pass. r=dom-core,sefeng

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47128 for changes under testing/web-platform/tests

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing Android wpt failures in non-html-documents.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /scroll-to-text-fragment/non-html-documents.html | Text directive allowed in text/plain - assert_equals: scrolled to fragment expected true but got false

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b41d6cd8b9c0
Backed out changeset 72e40f9471c4 for causing Android wpt failures in non-html-documents.html. CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c0948ba9ac8
Text Fragments: Separate json test case to let others pass. r=dom-core,sefeng

Comment 8

[Jan Jaeschke [:jjaschke]]

Android doing android things... sorry. Should be good now.

Comment 9

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/7c0948ba9ac8

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot