1907925 - Annotate profiles in before/after with before/after to denote which is which

Status: NEW

(Tree Management :: Perfherder, task, P3)

Description

[Greg Mierzwinski [:sparky]]

This bug is for finding a way to specify that a before profile in comment 0 comes from a before task, and the same with the after one, within the profile itself. It can be confusing to remember which is which - currently the only way to figure that out is by looking at the links and comparing with what you've opened. This is filed in the perfherder component because it's not possible to do this on the testing side.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

This can be implemented by adding a new URL search param to the profile link like ?profileName=<adding a nice human readable string>.

Currently we have this url coming from here: https://github.com/mozilla/treeherder/blob/ae3da6eb193083f68b84e29d76a281190a69c28f/ui/helpers/url.js#L116-L118
We can add another parameter here to pass the profile name.

Here's an example profile url from Bug 1924100:
https://profiler.firefox.com/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FApp_l-bATmqylpKakYehvQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_wikipedia.zip

(click a profile to see the name at the top left)

You can append that profile name, like:
https://profiler.firefox.com/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FApp_l-bATmqylpKakYehvQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_wikipedia.zip?profileName=wikipedia%20pageload%20before

(again, click a profile to see the name at the top left)

This url above will name the profile with "wikipedia pageload before". But good to note that with this we will lose the valuable information of whether it is a cold or warm load. Previously it was automatically named with wikipedia-pageload-cold/browser-cycle-1.json.gz. Now we don't have this anymore. Let me know if this is okay or not. We might need to change the code of the profiler to accommodate this.