1907935 - Ensure the "unhandledPromptBehavior" capability is not WebDriver classic only

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Originally noticed at: https://github.com/puppeteer/puppeteer/pull/12744

When running the session.new command for a bidi-only session the specified custom prompt behavior is not used but our BiDi implementation always falls back to the default value:

2024-07-12T13:23:11.960Z puppeteer:webDriverBiDi:SEND ► [
  '{"id":1,"method":"session.new","params":{"capabilities":{"alwaysMatch":{"acceptInsecureCerts":false,"unhandledPromptBehavior":"ignore","webSocketUrl":true}}}}'
]
2024-07-12T13:23:12.845Z puppeteer:webDriverBiDi:RECV ◀ [
  '{"type":"success","id":1,"result":{"sessionId":"b3f64299-5759-4902-a15e-19bafe933ce5","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"130.0a1","platformName":"linux","unhandledPromptBehavior":"dismiss and notify","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0","moz:buildID":"20240711215213","moz:headless":true,"moz:platformVersion":"6.6.15-2rodete2-amd64","moz:processID":1867689,"moz:profile":"/tmp/puppeteer_dev_firefox_profile-XXXXXXmfZUzr","moz:shutdownTimeout":60000,"proxy":{}}}}'
]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The problem here is actually that unhandledPromptBehavior is still listed as WebDriver classic only:
https://searchfox.org/mozilla-central/rev/54a5c4f14f3eb514a29e0cebcb5a095144bcd450/remote/shared/webdriver/Capabilities.sys.mjs#50

We should get this removed and a bidi-only test added.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1907935 - [remote] Make "unhandledPromptBehavior" capability not WebDriver classic only.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/002cacfd4d24
[remote] Make "unhandledPromptBehavior" capability not WebDriver classic only. r=webdriver-reviewers,jdescottes

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/002cacfd4d24

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The relevant upstream PR for Puppeteer is at: https://github.com/puppeteer/puppeteer/pull/12755

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1907935 - [remote] Make "unhandledPromptBehavior" capability not WebDriver classic only.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1907935 - [remote] Make "unhandledPromptBehavior" capability not WebDriver classic only.

Original Revision: https://phabricator.services.mozilla.com/D216642

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Puppeteer tests utilizing custom user prompt behaviors will fail
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: Only allows unhandledPromptBehavior to be usd in BiDi-only mode, which is tested well in classic mode
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/87514d614541