1907945 - Support labeled_{custom|memory|timing}_distribution metric types in FOG + GIFFT

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P2)

Description

[Chris H-C :chutten]

After bug 1657947 adds support for labeled_{custom|memory|timing}_distribution metrics, and after that code gets into a release, we'll need to have that release vendored into m-c and perform the necessary work to support the new metric types in FOG:

• Rust, C++, and JS APIs (and tests) - includes IPC
• GIFFT support (and tests) - these metric types provide APIs which'll allow us to mirror to Legacy keyed linear/exponential histograms (which is why bug 1885380 gets a See Also link)
• JOG support (and tests) - though the initial consumers are expected to be in platform, we expect frontend uses to abound as well

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1907945 - Upgrade to glean v60.4.0 r?TravisLong!

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1907945 - Update FOG to use new LabeledMetric ctor r?TravisLong!

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1907945 - Use i64 instead of u64 in custom_distribution ctor r?TravisLong!

This makes me sad, since these are for quantities that only permit unsigned
values. But this is what the Glean SDK was forced to use by early Kotlin,
and it simplifies codegen a little now that the signed types are re-exposed
by LabeledMetricData... so I guess we suffer.

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1907945 - Upgrade to glean_parser v14.3.0 r?TravisLong!

Comment 6

[Chris H-C :chutten]

Attachment: Bug 1907945 - Upgrade to glean v60.4.0 r?TravisLong!

Comment 7

[Chris H-C :chutten]

Attachment: Bug 1907945 - Update FOG to use new LabeledMetric ctor r?TravisLong!

Comment 8

[Chris H-C :chutten]

Attachment: Bug 1907945 - Use i64 instead of u64 in custom_distribution ctor r?TravisLong!

This makes me sad, since these are for quantities that only permit unsigned
values. But this is what the Glean SDK was forced to use by early Kotlin,
and it simplifies codegen a little now that the signed types are re-exposed
by LabeledMetricData... so I guess we suffer.

Comment 9

[Chris H-C :chutten]

Attachment: Bug 1907945 - Update docs on adding new labeled metric types to FOG r?TravisLong!

Comment 10

[Chris H-C :chutten]

Attachment: Bug 1907945 - Support labeled_custom_distribution metrics in FOG r?TravisLong!

Comment 11

[Chris H-C :chutten]

Attachment: Bug 1907945 - Support labeled_memory_distribution metrics in FOG r?TravisLong!

Comment 12

[Chris H-C :chutten]

Attachment: Bug 1907945 - Support labeled_timing_distribution metrics in FOG r?TravisLong!

This one is a little more complex because we need to support GIFFT for pure
Rust consumers (bug 1751448).

To do that we need to split the GIFFT impl from the core impl of FOG's Rust
timing_distribution implementation. That makes it so that the labeled_*-
specific submetric impl can dispatch to the core impl and call to GIFFT
independently.

It also makes the GIFFT code in timing_distribution.rs a little nicer
(to my eyes), which is a nice plus.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc66fc79f49e
Upgrade to glean_parser v14.3.0 r=TravisLong,mach-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/cd2bf02d8b29
Upgrade to glean v60.4.0 r=TravisLong,supply-chain-reviewers,mach-reviewers,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/63852846489b
Update FOG to use new LabeledMetric ctor r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/99c22c70694e
Use i64 instead of u64 in custom_distribution ctor r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/88858e864eb7
Update docs on adding new labeled metric types to FOG r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/c8925e80d2b9
Support labeled_custom_distribution metrics in FOG r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/820858301aa8
Support labeled_memory_distribution metrics in FOG r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/cfa2a54bceae
Support labeled_timing_distribution metrics in FOG r=TravisLong

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c8bb4b86267
Fix Bp-nu bustages. CLOSED TREE

Comment 15

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/cc66fc79f49e
https://hg.mozilla.org/mozilla-central/rev/cd2bf02d8b29
https://hg.mozilla.org/mozilla-central/rev/63852846489b
https://hg.mozilla.org/mozilla-central/rev/99c22c70694e
https://hg.mozilla.org/mozilla-central/rev/88858e864eb7
https://hg.mozilla.org/mozilla-central/rev/c8925e80d2b9
https://hg.mozilla.org/mozilla-central/rev/820858301aa8
https://hg.mozilla.org/mozilla-central/rev/cfa2a54bceae
https://hg.mozilla.org/mozilla-central/rev/9c8bb4b86267