1908048 - off by one errors in TrackBuffersManager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1908048 include last frame removed in eviction accounting r?alwu

This restores behavior to that prior to being accidentally changed in
https://hg.mozilla.org/mozilla-central/rev/f360c7c1251ed0a26d179beaf7cabbbdbdddbfe7#l1.52

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1908048 exit loops as soon as sufficient has been evicted r?alwu

Depends on D216644

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1908048 search from previous frame for previous keyframe r?padenot

Skipping the previous frame could mean that either

• for i = 1, mNextGetSampleIndex is not adjusted, or
• the loop jumps back to an earlier keyframe.

This restores behavior to that prior to being accidentally changed in
https://hg.mozilla.org/mozilla-central/rev/f360c7c1251ed0a26d179beaf7cabbbdbdddbfe7#l1.200

Depends on D216645

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1bd4e9c3d5b
include last frame removed in eviction accounting r=alwu

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a1bd4e9c3d5b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdb31ce74b3b
exit loops as soon as sufficient has been evicted r=alwu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70be5625d77a
search from previous frame for previous keyframe r=padenot

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fdb31ce74b3b

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/70be5625d77a