1908067 - Fix /html/dom/elements/global-attributes/dir-shadow-39.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Vincent Hilla [:vhilla]]

In Bug 1876163, I fixed most of the interop-dir test failures, only dir-shadow-39.html remains.

Comment 1

[Vincent Hilla [:vhilla]]

The test checks the html and css direction of an element. With the changes from Bug 1876163, the html direction should be correct. I.e. the div in the shadow dom matches the :dir(ltr) selector. What remains is that getComputedStyle(div).direction is empty.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Emilio, iirc, Vincent seemed to believe that we can use some tweaks in CSS to fix this problem. Unfortunately, he is not available to work on this. Is this something you can help or shed some lights? Thank you.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1908067 - Fix dir-shadow-39.html. r=#style,#layout

The reference is just wrong. The spec says that unassigned nodes have no
computed styles (they have nothing to inherit from).

https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle step 5:

If obj is not null, and elt is connected, part of the flat tree, and
...

Unassigned fallback content is not part of the flat tree, so we fail
that check.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

The test is just bogus, see comment 2.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f87404cfc945
Fix dir-shadow-39.html. r=smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47929 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f87404cfc945

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot