Closed Bug 1908089 Opened 2 years ago Closed 2 years ago

Several "extensions.webcompat" related undetected in "Core code"

Categories

(Webtools :: Searchfox, defect)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: masterquestionable, Unassigned)

References

Details

    https://searchfox.org/mozilla-central/search?q=extensions.webcompat

    Namely:
    |*| extensions.webcompat.enable_shims
    |*| extensions.webcompat.perform_injections
    |*| extensions.webcompat.perform_ua_overrides
    .
    Apparently working per:
    https://github.com/mozilla-extensions/webcompat-addon/issues/356


    I once also noted something non-existent in Core code but actually working in app.
    Couldn't remember the exact names.
    But how should such occur?

All "test files" shown in the results of your Searchfox search are, in fact, test files, as indicated by the /test/ subdirectory or the /testing/ root directory.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID

    Well... then it become interesting:
    Why would something not present in "Core code" actually work in final app?

Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Summary: Several "extensions.webcompat" related miscataloged as Test files → Several "extensions.webcompat" related undetected in "Core code"

Searchfox currently applies a simple set of path-based heuristics to perform pathkind categorization of files as a trivial means of results faceting.

Note that preference API uses rarely have an exact string mapping, especially when it comes to JS consumption of preferences; a search on `extensions. for example shows some dynamic pref branch building.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → INVALID

    Well... it then appears:
    Because the configs are written:
    echo -e 'H'"ell" '\x6F!';
    .
    ; alike... (echo "Hell o!" in Unix Shell)

    https://searchfox.org/mozilla-central/search?regexp=true&q=(enable_shim|perform_(injection|ua_override))s

    Note also:
    "(?: ...)" (non-capture group) didn't work.

(In reply to Master ? [:masterquestionable] from comment #4)

    Well... it then appears:
    Because the configs are written:
    echo -e 'H'"ell" '\x6F!';
    .
    ; alike... (echo "Hell o!" in Unix Shell)

I don't understand what you're trying to say here.

    https://searchfox.org/mozilla-central/search?regexp=true&q=(enable_shim|perform_(injection|ua_override))s

    Note also:
    "(?: ...)" (non-capture group) didn't work.

libre2 is used for regex and is limited to its syntax: https://github.com/google/re2/wiki/syntax (this is the link from the very terse description of the query language from the root page at https://searchfox.org/)

    Mere analogy no matter...
    Noticed as in: https://bugzilla.mozilla.org/show_bug.cgi?id=1877439#c1

    Seemingly to be the same issue as that on GitHub's code search:
    E.g. https://github.com/curl/curl/discussions/12397#discussioncomment-9603190

    Also "regexp" didn't recognize casting:
    E.g. https://searchfox.org/mozilla-central/search?regexp=1&q=(enable_shim|perform_(injection|ua_override))s
    .
    Potentially also:
    https://searchfox.org/mozilla-central/search?regexp&q=(enable_shim|perform_(injection|ua_override))s

See Also: → 1877439
You need to log in before you can comment on or make changes to this bug.