1908144 - Make GMP extraction support extracting Widevine from Chrome component update service CRX3 archives

Status: VERIFIED FIXED

(Core :: Audio/Video: GMP, enhancement)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

We already landed the necessary support for CRX3 in bug 1860397. The
difference with the compontent update service is that the Widevine
archives store the plugin files in a different folder within the archive
than before.

This patch makes it so that we extract all binaries/manifest files,
flattening the archive structure in the process. This should continue to
work for our present Widevine update mechanism, as well as the Chrome
component update service in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad5a3de26512
Add support for extracting Widevine plugins from Chrome component update service CRX3 archives. r=media-playback-reviewers,alwu

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ad5a3de26512

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9413016 [details]
Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

Beta/Release Uplift Approval Request

• User impact if declined: Without this patch, users will not be able to update the Widevine plugin after the fall 2024.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: With a fresh profile, ensure the Widevine plugin is installed/usable by visiting https://shaka-player-demo.appspot.com/demo/#build=uncompiled
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changes our extraction strategy to flatten the archive to maintain the same layout we expect from the archives today.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9413016 [details]
Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Required to do Widevine updates via the Chrome component update service
• User impact if declined: Without this patch, users will not be able to update the Widevine plugin after the fall 2024.
• Fix Landed on Version: 131
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changes our extraction strategy to flatten the archive to maintain the same layout we expect from the archives today.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

We already landed the necessary support for CRX3 in bug 1860397. The
difference with the compontent update service is that the Widevine
archives store the plugin files in a different folder within the archive
than before.

This patch makes it so that we extract all binaries/manifest files,
flattening the archive structure in the process. This should continue to
work for our present Widevine update mechanism, as well as the Chrome
component update service in the future.

Original Revision: https://phabricator.services.mozilla.com/D216703

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9413016 [details]
Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

Approved for 130.0b3

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e652f503e500

Comment 9

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox 131.0a1 (2024-08-08) and Firefox 130.0b3 (from Comment 8), using macOS 14.4, Windows 11 and Ubuntu 22.04, while following the steps described in Comment 4.
Widevine plugin is installed/usable when visiting https://shaka-player-demo.appspot.com/demo/#build=uncompiled.

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9413016 [details]
Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

Approved for 129.0.2

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/487dc0791a4a

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9413016 [details]
Bug 1908144 - Add support for extracting Widevine plugins from Chrome component update service CRX3 archives.

Approved for 128.2esr

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/8bec25fbb66f

Comment 14

[Donal Meehan [:dmeehan]]

:aosomond this has conflicts in esr115, could you please attached a rebased patch?

Comment 15

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Donal Meehan [:dmeehan] from comment #14)

:aosomond this has conflicts in esr115, could you please attached a rebased patch?

I attached the version for esr115 to phab, it applies cleanly for me:
https://phabricator.services.mozilla.com/D218843

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/2186157e7c85

Comment 17

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox 129.0.2, build ID 20240819150008, using macOS 14.4, Windows 11 and Ubuntu 22.04. Widevine plugin is installed/usable when visiting https://shaka-player-demo.appspot.com/demo/ with a fresh profile.

Comment 18

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox 115.15.0esr-build1 and on Firefox 128.2.0esr-build1 as well, using macOS 14.6, Windows 11 and Ubuntu 22.04.