1908148 - [Menu Redesign] Fix padding between menu item text and divider.

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Aarjav [:aarjav]]

Steps to reproduce

1. Open the menu
2. Go to the extensions sub-menu.

Expected behavior

• It needs to be 8 dp,

Actual behavior

• currently, it is 16 dp.

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Figma Link: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16634-331449&t=UF0WGEIgJ7ZQADI7-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1908148 - Part 1: Align the SelectableListItem with the latest designs

• Adjusts the SelectableItemIcon to have a size of 24dp
• Aligns the padding of the SelectableListItem with the latest designs
• Note: The list items in the bookmark and download screen should look the same according to https://www.figma.com/design/0vSTMqut1V0H4XU5k3iBT9?node-id=4576-63512&m=dev#891751815

Figma:

• https://www.figma.com/design/0vSTMqut1V0H4XU5k3iBT9/Bookmarks-2024?node-id=4576-63512&m=dev

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1908148 - Part 2: [Menu Redesign] Fix padding between menu item text and divider.

• Moves the padding from the Column containing the label and description to the root container of the ListItem and then manually adjusted the spacing within beforeListAction and afterListAction.

Figma:

• https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16634-331449&t=UF0WGEIgJ7ZQADI7-4
• https://www.figma.com/design/ujdiReypSypu2GhRgzArea/Android-Components?node-id=3016-12785&m=dev
• https://www.figma.com/design/fG8usV8bLIiVhD74FgkZOe/Android-UI?node-id=139-40920&m=dev

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a22c95b5e18
Part 1: Align the SelectableListItem with the latest designs r=android-reviewers,007,rsainani
https://hg.mozilla.org/integration/autoland/rev/4253aa871e0b
Part 2: [Menu Redesign] Fix padding between menu item text and divider. r=android-reviewers,007

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7a22c95b5e18
https://hg.mozilla.org/mozilla-central/rev/4253aa871e0b