Closed Bug 1908149 Opened 1 year ago Closed 1 year ago

[Menu Redesign] Fix divider thickness for menu item

Categories

(Firefox for Android :: Toolbar, task, P3)

Product:
Firefox for Android
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: aarjav, Assigned: gl, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1908149 - [Menu Redesign] Fix divider thickness for menu item
48 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

  1. Open menu
  2. Go to extensions sub-menu

Expected behavior

  • It needs to be 1 dp,

Actual behavior

  • Currently, it is 2 dp.

Device information

  • Firefox version:
  • Android device model:
  • Android OS version:

Any additional information?

Figma Link: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16634-331801&t=UF0WGEIgJ7ZQADI7-4

We need to change the divider width in https://searchfox.org/mozilla-central/rev/a95ca2357da6bccc6c5b12f662dd8a4e5bcbf892/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt#182.

Mentor: gl
Severity: -- → N/A
Type: defect → task
Keywords: good-first-bug
Priority: -- → P3
Blocks: menu-redesign-nightly-blockers
Summary: [Menu Redesign] fix divider thickness for menu item → [Menu Redesign] Fix divider thickness for menu item
Assignee: nobody → gl
Status: NEW → ASSIGNED
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56c2fbbce065 [Menu Redesign] Fix divider thickness for menu item r=android-reviewers,sanchaai

https://hg.mozilla.org/mozilla-central/rev/56c2fbbce065

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: