1908210 - Make the install complete strings in about:welcome's AddonsPicker configurable

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar]

The strings that show on the buttons beside each addon in about:welcome's AddonsPicker are currently hardcoded and the string have not been translated.

This blocked launch of a localized addons experiment (bug 1899357) which includes translated string for the install_label field which currently only exists in a test.

This bug is for adding install_label as an attribute for messages that include the addons picker. Goal is to uplift into 129 if possible to unblock this experiment.

Comment 1

[Jason Prickett]

Attachment: Bug 1908210 - Allow addons screen install button strings to be configurable r?mviar

Comment 2

[Phabricator Automation]

Comment on attachment 9413147 [details]
Bug 1908210 - Allow addons screen install button strings to be configurable r?mviar

Revision D216763 was moved to bug 1908212. Setting attachment 9413147 [details] to obsolete.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b24d56f929a
Allow addons screen install button strings to be configurable r=mviar,omc-reviewers

Comment 4

[Meg Viar]

[Tracking Requested - why for this release]: This patch addresses an issue blocking an experiment originally slated for Fx128 testing the inclusion of a localized addons picker in the about:welcome onboarding flow. The button labels for installing the addons were not configurable and showed up in English for all locales. This was missed in QA, but uncovered during a ready to launch meeting for the experiment. We'd like to see the attached patch uplifted into Fx129 to prevent further delay of the experiment. The template affected by these changes is currently only used in experiments and thus should not impact the default user experience.

Comment 5

[Donal Meehan [:dmeehan]]

Please attach a beta uplift request on this when ready.
Next week is the final week of beta for Fx129

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9b24d56f929a

Comment 7

[Jason Prickett]

Attachment: Bug 1908210 - Allow addons screen install button strings to be configurable r?mviar

Original Revision: https://phabricator.services.mozilla.com/D216763

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Experiment is delayed to 130
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps are present in this patch
• Risk associated with taking this patch: Minimal
• Explanation of risk level: The component is not in use in production or any live experiments, and will only be used in a future experiment for the time being.
• String changes made/needed: N/A
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a1d068ed1fa