1908318 - [Toolbar redesign] Default navbar shown instead of the custom tab's one after rotating the screen

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: NoButtonToOpenCustomTabInBrowser.mp4

After rotating the screen from portrait to landscape and back the default navigation bar is shown instead of the one configured for custom tabs.
This means different UI / functions / menu.
Can be observed more easily in the attached video by focusing on the "open in firefox" button which gets replaced with the "add new tab" button.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1908318 - Reinitialize also the custom tab's navigation bar after the screen rotates r=#android-reviewers

We benefit from the toolbar being owned by BaseBrowserFragment in that it is by default hidden
when in landscape but we need to also reinitialize it on top of the default behavior whenever
the screen is rotated while showing a custom tab.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0e36ad141f
Reinitialize also the custom tab's navigation bar after the screen rotates r=android-reviewers,mavduevskiy

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8a0e36ad141f

Comment 4

[Delia Pop (Android QA)]

Attachment: CustomTab_Navbar.mp4

Verified as fixed in latest Nightly 130.0a1 from 07/30. The custom tab's navigation bar remains displayed when changing the orientation.
Tested with the following devices:

• Google Pixel 8 Pro (Android 14)
• Xiaomi 12 Pro (Android 13)
• Samsung Tab S8 Ultra 5G (Android 14)