1908335 - Run android-lint tasks on firefox-android try

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Polly [:polly]]

In firefox-android preset try we aren’t running the android-lint (eg, lint(fenix)). This is different from the ktlint/detekt linters since this is running gradle listRepositories lint lintDebug mozilla-lint-rules:test.
We run this in autoland try and it would makes sense to run this in normal try builds as well so we can catch lint errors earlier.

Per https://phabricator.services.mozilla.com/D203335, it should be a matter of adding the names of the missing jobs to this list: https://searchfox.org/mozilla-central/rev/8c6edfe25c094e032a27722ef30f69555f556bf8/tools/tryselect/try_presets.yml#143
This can be tested by running ./mach try --preset firefox-android.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I would have expected the when: logic in android-lint.yml to schedule these jobs when needed the same way detekt/ktlint get automatically scheduled when needed. Do we just need to tweak that a bit maybe if there was a case that got missed?

Comment 2

[Julien Cristau [:jcristau]]

These tasks aren't automatically selected on try (always-target: false) because they require a build, so the when: logic doesn't kick in there.
Adding to the preset should be fine.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1908335 - Add lint tasks to the Android Try presets.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aa213d50572
Add lint tasks to the Android Try presets. r=jcristau DONTBUILD

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3aa213d50572