1908369 - 2.05 - 58.92% speedometer AngularJS-TodoMVC/Adding100Items (android-hw-a51-11-0-aarch64-shippable-qr, linux1804-64-nightlyasrelease-qr, macosx1015-64-nightlyasrelease-qr, windows11-64-nightlyasrelease-qr,) regression on Fri Jul 12

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Florin Bilt]

Perfherder has detected a browsertime performance change from push 6a254993ba42e4cee3cdf1548effc51f30d574e4.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
59%	speedometer AngularJS-TodoMVC/Adding100Items/Async	linux1804-64-shippable-qr	fission webrender	7.84 -> 12.46	Before/After
55%	speedometer AngularJS-TodoMVC/Adding100Items/Async	linux1804-64-nightlyasrelease-qr	fission webrender	7.89 -> 12.23	Before/After
34%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1400-64-shippable-qr	fission webrender	2.83 -> 3.80	Before/After
31%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1015-64-shippable-qr	fission webrender	6.77 -> 8.84	Before/After
29%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1015-64-nightlyasrelease-qr	fission webrender	7.13 -> 9.20	Before/After
25%	speedometer AngularJS-TodoMVC/Adding100Items/Async	windows11-64-shippable-qr	fission webrender	3.75 -> 4.68	Before/After
25%	speedometer AngularJS-TodoMVC/Adding100Items/Async	android-hw-a51-11-0-aarch64-shippable-qr	webrender	39.56 -> 49.32	Before/After
22%	speedometer AngularJS-TodoMVC/Adding100Items/Async	windows11-64-nightlyasrelease-qr	fission webrender	3.87 -> 4.72	Before/After
2%	speedometer AngularJS-TodoMVC/Adding100Items	macosx1015-64-nightlyasrelease-qr	fission webrender	98.77 -> 101.22	Before/After
2%	speedometer AngularJS-TodoMVC/Adding100Items	macosx1015-64-shippable-qr	fission webrender	97.01 -> 99.20	Before/After
2%	speedometer AngularJS-TodoMVC/Adding100Items	windows11-64-nightlyasrelease-qr	fission webrender	48.48 -> 49.48	Before/After
2%	speedometer AngularJS-TodoMVC/Adding100Items	windows11-64-shippable-qr	fission webrender	49.67 -> 50.69	Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1281

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1900009

Comment 2

[Ryan Safaeian [:rsafaeian]]

This patch introduced a change where the DOM would dispatch a new event, DOMPossibleUsernameInputAdded, when there is a formless input which has an autocomplete value of username. Taking a look at the source code for this test, https://github.com/WebKit/Speedometer/blob/main/resources/todomvc/architecture-examples/angular/src/app/todo-item/todo-item.component.html, the input elements do not have autocomplete=username , so I don't think that there should be any extra events fired. I will rerun these tests, investigate further, and I will give any updates I have.

Comment 3

[Pascal Chevrel:pascalc]

Ryan, we are nearing the end of the nightly cycle, what's the status of the resolution of this bug? Thanks

Comment 4

[Ryan Safaeian [:rsafaeian]]

Hi, unfortunately, there wasn't much progress in figuring out why this regression occurs.

Comment 5

[Dimi Lee [:dimi]]

Attachment: Bug 1908369 - Create formLike right before using it in processDOMPossibleUsernameInputAddedEvent r=#credential-management-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd30b6f39841
Create formLike right before using it in processDOMPossibleUsernameInputAddedEvent r=credential-management-reviewers,joschmidt

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/dd30b6f39841

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Florin Bilt]

(In reply to pstanciu from comment #7)

https://hg.mozilla.org/mozilla-central/rev/dd30b6f39841

Perfherder has detected a browsertime performance change from push dd30b6f39841c14c0463b957712f231188c40369.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
37%	speedometer AngularJS-TodoMVC/Adding100Items/Async	linux1804-64-shippable-qr	fission webrender	11.28 -> 7.11	Before/After
35%	speedometer AngularJS-TodoMVC/Adding100Items/Async	linux1804-64-nightlyasrelease-qr	fission webrender	11.23 -> 7.26	Before/After
33%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1015-64-nightlyasrelease-qr	fission webrender	9.23 -> 6.20	Before/After
33%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1015-64-shippable-qr	fission webrender	8.93 -> 6.03	Before/After
28%	speedometer AngularJS-TodoMVC/Adding100Items/Async	macosx1400-64-shippable-qr	fission webrender	3.81 -> 2.74	Before/After
...	...	...	...	...	...
2%	speedometer AngularJS-TodoMVC/Adding100Items	windows11-64-nightlyasrelease-qr	fission webrender	49.71 -> 48.67	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1631

For more information on performance sheriffing please see our FAQ.

Comment 10

[Dimi Lee [:dimi]]

Attachment: Bug 1908369 - Create formLike right before using it in processDOMPossibleUsernameInputAddedEvent r=#credential-management-reviewers

Original Revision: https://phabricator.services.mozilla.com/D218517

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Slower page load time in certain cases
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: No
• Risk associated with taking this patch: If there is bug in the patch, users will not see the fill username autocomplete popup
• Explanation of risk level: Low risk since we are just doing lazy initialization for one object
• String changes made/needed: None
• Is Android affected?: yes

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/82669bfd9dff