1908418 - Make each window have a groups array which includes all of the tab groups currently present on the tab bar including a unique identifier

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Comment 1

[Stephen Thompson [:sthompson]]

This is based on the following session data storage implementation plan https://docs.google.com/document/d/1-Lo46NxnAq5TDAwHSLjy5RMc9lOHEKT7nMKAaaUoWek/edit#heading=h.qb7w06lvvqsi

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 1908418 - Add open tab groups to session store r=dwalker,jswinarton,dao

This adds tab groups and their state data to the session store. For any tabs that are in tab groups, this patch adds the group ID into the tab state.

This change has a number of limitations that will be addressed in future bugs. Most notably, tab groups will not be restored from session state -- this change just records the tab group state data. Another important limitation is that when users remove tab groups, they will no longer appear in the session store.

This patch is only intended to lay the initial groundwork for storing tab group data in the session store.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ded63123e6c
Add open tab groups to session store r=jswinarton,dao,sessionstore-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing multiple perma failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/7deb551b5bdf633935ce6bd487c0bb804e3189a5

Push with failures

Failure log -> dt

Failure log -> bc

Comment 5

[Stephen Thompson [:sthompson]]

(In reply to Sandor Molnar[:smolnar] from comment #4)

Backed out for causing multiple perma failures
Taking a look, thanks. The browser chrome issue looks related to my changes. The devtools issue is unexpected, I'll dig into it.

Comment 6

[Sandor Molnar[:smolnar]]

(In reply to Stephen Thompson from comment #5)

(In reply to Sandor Molnar[:smolnar] from comment #4)

Backed out for causing multiple perma failures
Taking a look, thanks. The browser chrome issue looks related to my changes. The devtools issue is unexpected, I'll dig into it.

backfills indicate it's coming from your push

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d59c65301d3
Add open tab groups to session store r=jswinarton,dao,sessionstore-reviewers

Comment 8

[Stephen Thompson [:sthompson]]

Looks like there was a difference between running Array.map on an array from gBrowser vs. creating a new array in SessionStore and Array.pushing elements onto it. I queued the fix for landing.

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9d59c65301d3