190848 - When trying to add a new product I get a 'software error'.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P1)

Description

[Grzegorz Stelmaszek]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: 2.17.3

When I'm trying to add a new product, I get the following software error:

INSERT INTO group_control_map (group_id, product_id, entry, membercontrol, 
othercontrol, canedit) VALUES entry, control, canedit) VALUES (12, 7, 0, 1, 0, 
0): You have an error in your SQL syntax near 'entry, control, canedit) VALUES 
(12, 7, 0, 1, 0, 0)' at line 1 at globals.pl line 238.




Reproducible: Always

Steps to Reproduce:




Despite the error, product seems to be added correctly.

Comment 1

[Jussi Sirpoma]

I can reproduce this with the latest version from CVS. But I doubt the product
is fully created if the statement above has not been executed.

Comment 2

[Jussi Sirpoma]

http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/editproducts.cgi#384

                SendSQL("INSERT INTO group_control_map " .
                        "(group_id, product_id, entry, " .
                        "membercontrol, othercontrol, canedit) VALUES " .
                        "entry, control, canedit) VALUES " .
                        "($grpid, $product_id, 0, " .
                        CONTROLMAPSHOWN . ", " .
                        CONTROLMAPNA . ", 0)");
 
This looks like a merge thing (the fourth line is extra?) but better to have the
author look at it so cc:ing Joel.

Comment 3

[Gervase Markham [:gerv]]

Joel: is this still a problem?

Gerv

Comment 4

[Jussi Sirpoma]

Attachment: Remove the fourth line

I need to create a product so here is a patch which removes the extra line.

Comment 5

[Dave Miller [:justdave]]

-> patch author

Comment 6

[Jouni Heikniemi]

Checked in, marking fixed.

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.34; previous revision: 1.33