Closed Bug 190848 Opened 22 years ago Closed 21 years ago

When trying to add a new product I get a 'software error'.

Categories

(Bugzilla :: Administration, task, P1)

2.17.3

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: greg, Assigned: jussi)

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: 2.17.3

When I'm trying to add a new product, I get the following software error:

INSERT INTO group_control_map (group_id, product_id, entry, membercontrol, 
othercontrol, canedit) VALUES entry, control, canedit) VALUES (12, 7, 0, 1, 0, 
0): You have an error in your SQL syntax near 'entry, control, canedit) VALUES 
(12, 7, 0, 1, 0, 0)' at line 1 at globals.pl line 238.




Reproducible: Always

Steps to Reproduce:




Despite the error, product seems to be added correctly.
Version: unspecified → 2.17.3
I can reproduce this with the latest version from CVS. But I doubt the product
is fully created if the statement above has not been executed.
http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/editproducts.cgi#384

                SendSQL("INSERT INTO group_control_map " .
                        "(group_id, product_id, entry, " .
                        "membercontrol, othercontrol, canedit) VALUES " .
                        "entry, control, canedit) VALUES " .
                        "($grpid, $product_id, 0, " .
                        CONTROLMAPSHOWN . ", " .
                        CONTROLMAPNA . ", 0)");
 
This looks like a merge thing (the fourth line is extra?) but better to have the
author look at it so cc:ing Joel.
Severity: major → blocker
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.18
Joel: is this still a problem?

Gerv
I need to create a product so here is a patch which removes the extra line.
Attachment #116619 - Flags: review?(bugreport)
Attachment #116619 - Flags: review?(bugreport) → review+
Flags: approval?
-> patch author
Assignee: justdave → jussi
Flags: approval? → approval+
OS: Windows 2000 → All
Hardware: PC → All
Checked in, marking fixed.

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.34; previous revision: 1.33
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: