1908497 - [Toolbar redesign] Address bar tab preview does not have the share and reload action buttons

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[Roger Yang [:royang]]

Currently the tab preview for the address bar when swiping does not have the action buttons.
This includes with or without navigation bar and in portrait and landscape.

Comment 1

[Chris Peterson [:cpeterson]]

P3 because we don't need this bug in our current sprint.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[[:harrisono]]

Attachment: Tab Preview swipe with navigation toolbar off

This shows the tab preview in Nightly v131.0a1 with the Navigation toolbar feature off.

Comment 4

[[:harrisono]]

Attachment: Tab Swipe preview with nav toolbar on

Nightly v131.0a1 with nav toolbar feature turned on.

Comment 5

[[:harrisono]]

Attachment: Bug 1908497 - change TabPreview to include changes to the toolbar

Comment 6

[[:harrisono]]

Attachment: Added reload and share action to tab preview

Added reload and share actions to tab preview addressbar

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be40fae8f7c8
change TabPreview to include changes to the toolbar r=android-reviewers,tchoh

Comment 8

[[:harrisono]]

Attachment: Bug 1908497 - fix TabPreview navigation toolbar alignment with bottom AddressBar

Comment 9

[[:harrisono]]

What is the expected scope change of this?
Is this part of the AddressBar swiping behavior that is expected in phase 3?
Are we adding just the share and reload buttons to the mock AddressBar in the TabPreview or is there more actions/UI elements that are site-dependent to be expected like the lock security icon or the Reader mode?

as it stands right now, the TabPreview is pretty agnostic about what the site being previewed is but adding conditional actions to the TabPreview can increase the complexity and risk of regression.

Comment 10

[[:harrisono]]

Also, the summary mentions the menu button disappearing but it is not in the AddressBar when the Navigation toolbar is enabled.
when the Navigation toolbar is not enabled, the menu button loads fine in the TabPreview.

Comment 11

[Roger Yang [:royang]]

The requirement here is to only have the action buttons shows up (refresh, share) in the preview.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e634eefd7ed
fix TabPreview navigation toolbar alignment with bottom AddressBar r=android-reviewers,tchoh

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/be40fae8f7c8
https://hg.mozilla.org/mozilla-central/rev/3e634eefd7ed

Comment 14

[Aarjav [:aarjav]]

This bug can worked on during the later phases when we introduce the tab swipe animation. This isn't a blocker for the beta experiment.