1908625 - SVG <image> element not rerendering after removeAttribute("xlink:href")

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[marti.kanera]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

1. Create an SVG element with an <image> tag in the HTML.
2. Set the xlink:href attribute on the <image> tag to point to an image URL.
3. Use JavaScript to call image.removeAttribute('xlink:href') on the <image> element.

Actual results:

Even though retrieving the attribute using image.getAttribute("xlink:href") returns null, the image itself remains visible.

Expected results:

The image should no longer be visible when the xlink:href attribute is removed.

Comment 1

[marti.kanera]

Here is an example demonstrating the issue: https://codepen.io/martinkanera/pen/VwJvdZX

Comment 2

[Robert Longson [:longsonr]]

Attachment: testcase 1 (using removeAttributeNS)

Comment 3

[Daniel Holbert [:dholbert]]

regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2601aa4526288006e2dc3f4e84f5735db5da60e9&tochange=4d770d6a88770f9af267a8a34e002f955b0c37cd

Probably regression from this commit in there:
Emilio Cobos Álvarez — Bug 1756750 - Don't reframe <svg:image> on loading / broken changes. r=jfkthame

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 9413650 [details]
testcase 1 (using removeAttributeNS)

Note, Robert adjusted the testcase to use removeAttributeNS (whereas the reporter's original testcase used removeAttribute), in case removeAttributeNS worked better here.

In fact both versions work before the regression-range, and both fail after the regression-range.

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: testcase 2 (using removeAttribute)

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1756750

:emilio, since you are the author of the regressor, bug 1756750, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Robert Longson [:longsonr]]

Attachment: Bug 1908625 - SVG image elements should update if their href is removed r=emilio

Comment 8

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=0c08fcf5c5ae40a9fa979b3a164b437c411d6baf

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ec63326fa5
SVG image elements should update if their href is removed r=emilio

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47206 for changes under testing/web-platform/tests

Comment 11

[Daniel Holbert [:dholbert]]

I triggered lando at longsonr's request (he's AFK but wanted to get this in), but then I noticed some minor things I'd like to improve in the tests -- and I think one of the changes might reveal a piece of this that's not-yet-fixed. I'll file a followup bug or two.

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d7ec63326fa5

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:longsonr, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Robert Longson [:longsonr]]

Given that it regressed two years ago, I imagine it's not encountered that much.