1908666 - Tab hover preview still visible with context menu opened in certain conditions

Status: REOPENED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

Attachment: Gif showing the issue

Found in

• Latest Nightly 130.0a1

Affected versions

• Latest Nightly 130.0a1

Tested platforms

• Affected platforms: Windows 11 and Ubuntu 22.04
• Unaffected platforms: MacOS 13.6

Preconditions

• Set browser.tabs.hoverPreview.enabled as true if not already set.

Steps to reproduce

1. Open a few tabs
2. Restart the browser
3. Right click on the pocket button and hover over the tabs

Expected result

• The preview is not shown when context menu is opened

Actual result

• The tab hover preview is shown

Regression range

• Not sure yet if this is a regression or not, will check ASAP.

Additional notes

• I noticed that this only happens only once after the browser starts/restarts, I was not able to reproduce it in the same session more than once.

Comment 1

[Jeremy Swinarton]

Attachment: Bug 1908666: Prevent THP from opening when other panel is animating r?dwalker

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5403dec7aed
Prevent THP from opening when other panel is animating r=dwalker,tabbrowser-reviewers

Comment 3

[Chris Peterson [:cpeterson]]

Jeremy says we don't need to uplift to Beta 129.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b5403dec7aed

Comment 5

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

Attachment: Gif showing the issue 2

This is still reproducible, now it's a bit worse since the hover will still be on even after navigating to any tabs.
The panel will be dismissed after clicking on a tab 2 times.
Build used: https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=ef22d470bb62b9898059a38214c0b95923d74e7c

Comment 6

[Jeremy Swinarton]

Interesting, this seems to only affect context menus (as opposed to panels) on Windows, because the attribute we check for on panel instantiation is absent on Windows for some reason. I opened bug1909694 to track this.

We only rely on checking for this attribute on the first load of THP (which is lazy-loaded) -- after initialization we can listen for events on other panels and context menus. This is the reason why this can only happen the first time that a tab is hovered over in a session.

Given that this is only possible to invoke in a very small corner case, is it necessary to track this as a P1? This feel more like P3 territory imo.

Comment 7

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

We as QA don't set priorities to bugs, we only set the severity (which on its own is debatable, in this case S4 since it's kind of an edge case), engineering sets the priority of the bugs. But I agree that this is a corner case since its happening only once at the start of a session.