Home and newtab add back tileId to merino telemetry
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
People
(Reporter: thecount, Assigned: thecount)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt])
Attachments
(2 external files)
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Comment 1•2 years ago
|
||
Comment 3•2 years ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D217004
Updated•2 years ago
|
Comment 4•2 years ago
|
||
beta Uplift Approval Request
- User impact if declined: This would impact the timeline for topics experiments which delays the feature being released to users
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Follow test plan steps here: User impact if declined
- Risk associated with taking this patch: No impact to users, very few code changes, and essentially rolling back to a previous pattern we had used for years.
- Explanation of risk level: Low
- String changes made/needed: No
- Is Android affected?: no
Comment 5•2 years ago
|
||
[Tracking Requested - why for this release]: This would impact the timeline for topics experiments which delays the feature being released to users and risk wise, surfaces no impact to users, very few code changes, and rolls back to a previous pattern we had used for years.
cc/ :thecount
Comment 6•2 years ago
|
||
beta Uplift Approval Request
- User impact if declined: This would impact the timeline for topics experiments which delays the feature being released to users
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Follow test plan steps here: https://phabricator.services.mozilla.com/D217004
- Risk associated with taking this patch: No impact to users, very few code changes, and essentially rolling back to a previous pattern we had used for years.
- Explanation of risk level: Low
- String changes made/needed: No
- Is Android affected?: no
Updated•2 years ago
|
Comment 7•2 years ago
|
||
| bugherder | ||
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 9•2 years ago
|
||
I have verified that titleId is now being collected when browser.newtabpage.activity-stream.discoverystream.merino-provider.enabled is set to true for "impression", "click", and "dismiss" events on the latest Nighty 130.0a1 (20240722214643) and the latest Firefox Beta 129.0b7 (20240722091823) on Windows 10, macOS 14, Ubuntu 22.
@Scott, I've noticed that we don't collect "position" for "dismiss" events and we do for impression and click. Could you please confirm whether this is intended or not?
| Assignee | ||
Comment 10•2 years ago
•
|
||
Yeah, dismiss should have position.
https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/pocket_dismiss
It's in there, so it was expected.
The code is also sending it: https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/TelemetryFeed.sys.mjs#1120
So looks like a bug.
Do you think this is a recent regression?
I'll take a closer look later today.
Comment 11•2 years ago
|
||
It doesn't look like a recent regression. I can reproduce this behavior starting with builds that contain bug 1904594. Builds before this bug don't send a dismiss event. This being said, I've logged this here.
Description
•