Closed Bug 1908710 Opened 2 years ago Closed 2 years ago

Home and newtab add back tileId to merino telemetry

Categories

(Firefox :: New Tab Page, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
130 Branch
Tracking Status
firefox129 + verified
firefox130 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt])

Attachments

(2 external files)

No description provided.
Summary: Home and newtab add back tileId to merio telemetry → Home and newtab add back tileId to merino telemetry
Assignee: nobody → sdowne
Pushed by sdowne@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b316f913011 Home and newtab add back tileId to merino telemetry r=home-newtab-reviewers,maxx
Attachment #9413874 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: This would impact the timeline for topics experiments which delays the feature being released to users
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: Follow test plan steps here: User impact if declined
  • Risk associated with taking this patch: No impact to users, very few code changes, and essentially rolling back to a previous pattern we had used for years.
  • Explanation of risk level: Low
  • String changes made/needed: No
  • Is Android affected?: no
Flags: qe-verify+

[Tracking Requested - why for this release]: This would impact the timeline for topics experiments which delays the feature being released to users and risk wise, surfaces no impact to users, very few code changes, and rolls back to a previous pattern we had used for years.

cc/ :thecount

beta Uplift Approval Request

  • User impact if declined: This would impact the timeline for topics experiments which delays the feature being released to users
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: Follow test plan steps here: https://phabricator.services.mozilla.com/D217004
  • Risk associated with taking this patch: No impact to users, very few code changes, and essentially rolling back to a previous pattern we had used for years.
  • Explanation of risk level: Low
  • String changes made/needed: No
  • Is Android affected?: no
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Attachment #9413874 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that titleId is now being collected when browser.newtabpage.activity-stream.discoverystream.merino-provider.enabled is set to true for "impression", "click", and "dismiss" events on the latest Nighty 130.0a1 (20240722214643) and the latest Firefox Beta 129.0b7 (20240722091823) on Windows 10, macOS 14, Ubuntu 22.

@Scott, I've noticed that we don't collect "position" for "dismiss" events and we do for impression and click. Could you please confirm whether this is intended or not?

Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(sdowne)

Yeah, dismiss should have position.

https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/pocket_dismiss

It's in there, so it was expected.

The code is also sending it: https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/TelemetryFeed.sys.mjs#1120

So looks like a bug.

Do you think this is a recent regression?

I'll take a closer look later today.

Flags: needinfo?(sdowne)

It doesn't look like a recent regression. I can reproduce this behavior starting with builds that contain bug 1904594. Builds before this bug don't send a dismiss event. This being said, I've logged this here.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: