1908718 - Icons for local search appear in the chiclet are not dynamic to theming

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Josh Berman]

Attachment: Screenshot 2024-07-18 at 18.08.32.png

Expected outcome:

1. User opens Firefox in dark mode.
2. User selects a local search like bookmarks or tabs
3. That local search Icon and Title appear in the chiclet to the left side of the address bar.
4. The local search icon is default icon color for dark mode.

Actual outcome:

1. User opens Firefox in dark mode.
2. User selects a local search like bookmarks or tabs
3. That local search Icon and Title appear in the chiclet to the left side of the address bar.
4. The local search icon is NOT default icon color for dark mode.

Comment 1

[Dana Lucaci, Desktop QA]

I was able to reproduce the issue with Firefox 130.0a1 (2024-07-18) on Windows 10, Ubuntu 22, and macOS 14.
However, with Firefox 134.0a1 (2024-10-31) on Windows 10, Ubuntu 22, and macOS 14, the issue is reproducible only if HCM is also enabled.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Screenshot 2024-12-29 at 10.42.18.png

I think this is fixed? On MacOS with latest nightly enabled HCM and Dark Mode and the icon colours are as expected here

Comment 4

[Dale Harvey (:daleharvey)]

Gonna resolve WFM for the moment, but if anyone can reproduce then please reopen

Comment 5

[Dana Lucaci, Desktop QA]

I reopened this bug since the issue still occurs in a recent Nightly build (20250114093520)on macOS 14, Win 10 and Ubuntu 22.04. While the problem seems fixed when opening the Unified Search button dropdown, it still occurs in the address bar when clicking on one of the local search option, such as tabs or bookmarks

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Bug 1908718 - Ensure local chicklet icons are correctly coloured. r=dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d46a948dadd4
Ensure local chicklet icons are correctly coloured. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d46a948dadd4

Comment 9

[Dana Lucaci, Desktop QA]

The issue is verified fixed with Firefox 136.0a1 (20250122165122) on Windows 10, macOS 14 and Ubuntu 22