1908727 - Add scalar probes for the current state of the BackupService

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

We need to record boolean values for:

1. Is the backup service enabled?
2. Are scheduled backups enabled?
3. Are encrypted backups enabled?

We also want some coarse information on where the backup is being stored. This will be a numeric value

1 = default location
2 = non-default location
3 = location that seems to be a known cloud storage provider (seems to be a Dropbox, OneDrive, Box folder... this one might be tricky)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

See https://docs.google.com/spreadsheets/d/1WdO0Enl6Z7y-rng22WuAziRneqGYNk7iJUqVnrRWFKM/edit?gid=356345865#gid=356345865 - specifically rows 5, 6 and 7 for the expected probe names.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1908727 - Add probes for the initial state and configuration for BackupService. r?#backup-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d68ad927ddb
Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_startup_mainthreadio.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a3e954b97786a510a2c50263d0dbdf5d068a44ed

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/334773fe02f0
Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing codecs failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | MOZ_ASSERT(NS_IsMainThread()) [@ mozilla::ClearOnShutdown<mozilla::Atomic<nsBaseHashtable<nsIntegralHashKey<unsigned int, 0>, mozilla::intl::Script, mozilla::intl::Script, nsDefaultConverter<mozilla::intl::Script, mozilla::intl::Script> >*, (mozilla::MemoryOrdering)2, void> >(mozilla::Atomic<nsBaseHashtable<nsIntegralHashKey<unsigned int, 0>, mozilla::intl::Script, mozilla::intl::Script, nsDefaultConverter<mozilla::intl::Script,

Comment 7

[Mike Conley (:mconley) (:⚙️)]

I really can't see how this patch could have caused this assertion failure on Android. I've pushed the patch to try on the latest tip of mozilla-central, and not seeing the failure after many retriggers: https://treeherder.mozilla.org/jobs?repo=try&revision=c08dc38cfa12666095afe8be996244dde389df7f

I'm going to try relanding this now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/557aef354185
Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/557aef354185