Closed Bug 1908782 Opened 3 months ago Closed 3 months ago

Align gear button beta label in translation panel

Categories

(Fenix :: Translations, enhancement, P1)

Firefox 130
All
Android
enhancement

Tracking

(firefox130 verified)

VERIFIED FIXED
130 Branch
Tracking Status
firefox130 --- verified

People

(Reporter: Dasha, Assigned: olivia)

References

Details

(Whiteboard: [fxdroid][foundation][translations:130])

Attachments

(3 files)

Steps to reproduce

  1. Make your system language English
  2. Open the Firefox Nightly app and navigate to it.wikipedia.org
  3. Activate the translation panel. (The translations panel should pop up, or you can activate it by clicking on the translations icon in the toolbar, or by selecting the "translate" option in the application menu.)
  4. Observe the placement of the gear menu relative to the text and beta label.

Expected behavior

The gear menu should be aligned with the beta label and have consistent padding as the design specifies.

Actual behavior

The gear menu is tightly placed next to the text area. Also when the title gets longer due to longer strings, the stacking looks miss-aligned with the top of the text

Device information

Firefox version: 130.0a1 (Build #2016033063)
Android device model: Galaxy S21 5G (SM-G991W)
Android OS version: 12

Any additional information?

Refer to the attached screenshots and the design files here:
https://www.figma.com/design/GT6oZLFw32LiCwKl5GOMWD/Full-Page-Translation?node-id=14254-42625&t=iR8Z5YjKVl2Wamc9-4

Flags: needinfo?(ohall)
Severity: -- → S3
Attached image image.png
Duplicate of this bug: 1908781
Severity: S3 → N/A
Flags: needinfo?(ohall)
Priority: -- → P1
Whiteboard: [fxdroid][foundation][translations:130]
Assignee: nobody → ohall

This patch moves the gear icon to the same level as the beta label and
adjusts some padding between layers.

Flags: qe-verify+
Pushed by ohall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0ab6e599f8f Align gear button beta label in Android translation panel r=android-reviewers,giorga
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Attached image 1908782.png

Verified as fixed on the Fenix Nightly 130.0a1 build from 7/28, with Samsung Galaxy S24 (Android 14), and Lenovo TB-X606X (Android 10).

The BETA label and the settings icon are alligned as in the screenshot.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: