1908789 - Crash in [@ mozilla::dom::ContentParent::IsDead]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

8 crash reports from 7 installs of Firefox 129 betas, all with 32-builds on Windows and the crash after Firefox had been running for more than an hour.

Does anything need to be done?

Crash report: https://crash-stats.mozilla.org/report/index/70756e25-d14f-4ca7-9690-883720240718

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::dom::ContentParent::IsDead() const  dom/ipc/ContentParent.h:432
0  xul.dll  mozilla::dom::ContentParent::WaitForLaunchAsync(mozilla::hal::ProcessPriority...  dom/ipc/ContentParent.cpp:1042
1  xul.dll  mozilla::PreallocatedProcessManagerImpl::AllocateNow()  dom/ipc/PreallocatedProcessManager.cpp:319
2  xul.dll  mozilla::detail::RunnableMethodArguments<>::apply<mozilla::ipc::PortLink::Por...  xpcom/threads/nsThreadUtils.h:1085
2  xul.dll  std::invoke(mozilla::detail::RunnableMethodArguments<>::apply<mozilla::ipc::P...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/type_traits:1729
2  xul.dll  std::_Apply_impl(mozilla::detail::RunnableMethodArguments<>::apply<mozilla::i...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1077
2  xul.dll  std::apply(mozilla::detail::RunnableMethodArguments<>::apply<mozilla::ipc::Po...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1088
2  xul.dll  mozilla::detail::RunnableMethodArguments<>::apply(mozilla::ipc::PortLink::Por...  xpcom/threads/nsThreadUtils.h:1083
2  xul.dll  mozilla::detail::RunnableMethodImpl<RefPtr<mozilla::ipc::PortLink::PortObserv...  xpcom/threads/nsThreadUtils.h:1134
3  xul.dll  mozilla::RunnableTask::Run()  xpcom/threads/TaskController.cpp:580

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1908789 - Check for null return from MakePreallocProcess, r=#ipc-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc2642d29858
Check for null return from MakePreallocProcess, r=ipc-reviewers,mccr8

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fc2642d29858

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nika, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9413814 [details]
Bug 1908789 - Check for null return from MakePreallocProcess, r=#ipc-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Rare crash when starting prealloc processes (mostly on 32-bit windows)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adding a null check
• String changes made/needed: None
• Is Android affected?: Yes

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9413814 [details]
Bug 1908789 - Check for null return from MakePreallocProcess, r=#ipc-reviewers!

Approved for 129.0b9

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/357922151d99