1908837 - Crash in [@ mozilla.appservices.logins.LoginsApiException$IncorrectKey: at mozilla.appservices.logins.FfiConverterTypeLoginsApiError.read(logins.kt)]

Status: NEW

(Firefox for Android :: Accounts and Sync, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/17626d5a-2714-437c-915e-fccdd0240719

Top 10 frames:

0  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  read  logins.kt:13
1  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  read  logins.kt:1
2  mozilla.appservices.logins.FfiConverter$DefaultImpls  liftFromRustBuffer  logins.kt:14
3  mozilla.appservices.logins.FfiConverterRustBuffer$DefaultImpls  liftFromRustBuffer  logins.kt:7
4  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  liftFromRustBuffer  logins.kt:2
5  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  liftFromRustBuffer  logins.kt:1
6  mozilla.appservices.logins.FfiConverterRustBuffer$DefaultImpls  lift  logins.kt:7
7  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  lift  logins.kt:3
8  mozilla.appservices.logins.FfiConverterTypeLoginsApiError  lift  logins.kt:2
9  mozilla.appservices.logins.LoginsApiException$ErrorHandler  lift  logins.kt:2

Comment 1

[Jeff Boek [:boek]]

Hey Mark, are FfiConverterTypeLoginsApiError coming from application services?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Yes - this is coming from app-services. It indicates that something in Fenix was calling logins.decryptLogin() but supplied the wrong decryption key. This likely means that the key was lost from the keychain (or wherever it is stored), and when generating a new one we failed to wipe all the existing logins - so the DB is full of logins encrypted with a lost key.

Comment 3

[Jeff Boek [:boek]]

Looking at the reports it looks like this is only happening for a small number of users (less than 50). Going to mark this as a P3 until we can get some steps to reproduce.