Closed Bug 1908920 Opened 2 years ago Closed 1 year ago

toolkit/themes/shared/icons/loading.svg does not respect prefers-reduced-motion

Categories

(Toolkit :: Themes, defect, P1)

Product:
Toolkit
Component:
Themes
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- fixed
firefox128 --- wontfix
firefox129 --- wontfix
firefox130 --- wontfix
firefox131 --- fixed

People

(Reporter: nordzilla, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: access, regression)

Attachments

(1 file)

Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr128+
Details | Review

Description

When Bug 1870320 introduced toolkit/themes/shared/icons/loading.svg, which is an animated SVG, I neglected to add rules to the SVG itself to respect prefers-reduced-motion. We need to ensure that this icon respects this a11y preference.

Steps to implement

Tests to implement

  • This is a UI style change that may not be easily testable in automation, but should be manually verified.

Ensures that the animation rules inside of loading.svg respect the
user's prefers-reduced-motion settings.

Set release status flags based on info from the regressing bug 1870320

status-firefox128: --- → affected
status-firefox129: --- → affected
status-firefox130: --- → affected
status-firefox-esr115: --- → unaffected
status-firefox-esr128: --- → affected
Attachment #9413815 - Attachment description: WIP: Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion → Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion r=gijs
Blocks: 1904040
OS: Unspecified → All
Hardware: Unspecified → Desktop
Component: Theme → Themes
Priority: -- → P1
Product: Firefox → Toolkit

Thank you for catching and working on fixing it, Erik!

Accessibility Severity: --- → s3

Set release status flags based on info from the regressing bug 1870320

status-firefox131: --- → affected
Attachment #9413815 - Attachment description: Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion r=gijs → Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla
Blocks: 1914651
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b72ff01fb825 Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla,desktop-theme-reviewers,sfoster
Assignee: enordin → dao+bmo
Status: NEW → ASSIGNED

https://hg.mozilla.org/mozilla-central/rev/b72ff01fb825

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox131: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
Regressions: 1915650

Please nominate this for ESR128 uplift when you get a chance.

Flags: needinfo?(dao+bmo)
Blocks: 1924496

Comment on attachment 9413815 [details]
Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Accessibility fix
  • User impact if declined: See comment 0. Impact is limited to the Translation icon and panel.
  • Fix Landed on Version: 131
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a theme-only fix that only touches one SVG file and a few CSS rules, and I'm told it applies cleanly on esr128.
Flags: needinfo?(dao+bmo)
Attachment #9413815 - Flags: approval-mozilla-esr128?

Comment on attachment 9413815 [details]
Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla

Approved for 128.4esr.

Attachment #9413815 - Flags: approval-mozilla-esr128? → approval-mozilla-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: