Closed Bug 1908922 Opened 2 months ago Closed 1 day ago

Layout of dedicated button has extra space and incorrect icon behaviour

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox132 --- fixed

People

(Reporter: jberman, Assigned: daleharvey)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [sng-scrubbed])

Attachments

(2 files)

Screenshot 2024-07-19 at 9.28.55 AM.png
161.64 KB, image/png
Details
Bug 1908922 - Update dedicated search button paddings to match UX spec. r=Mak
48 bytes, text/x-phabricator-request
Details | Review

Expected outcome:

  1. In state when URL bar is focused, but dropdown is closed, the Dedicated search button is snug against left side of URL bar.

Actual outcome:

  1. In state when URL bar is focused, but dropdown is closed, the Dedicated search button has a small gap between left side of URL bar.
Blocks: 1891862
Severity: -- → S4
No longer depends on: 1891862
Priority: -- → P3
Whiteboard: [sng-scrubbed]
Assignee: nobody → dharvey

Josh brought up several issues with the icons layout and behaviour and it isnt feasible to address them seperately so merging into one layout update

Summary: Unexpected space between dedicated search button and left side of address bar → Layout of dedicated button has extra space and incorrect icon behaviour
Duplicate of this bug: 1908921
Duplicate of this bug: 1913202
Blocks: 1916679

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:daleharvey, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Flags: needinfo?(dharvey)
Attachment #9422551 - Attachment description: WIP: Bug 1908922 - Update dedicated search button to match UX spec → Bug 1908922 - Update dedicated search button to match UX spec. r=Mak
Severity: S4 → S3
Flags: needinfo?(dharvey)
Status: NEW → ASSIGNED
Attachment #9422551 - Attachment description: Bug 1908922 - Update dedicated search button to match UX spec. r=Mak → Bug 1908922 - Update dedicated search button paddings to match UX spec. r=Mak
Duplicate of this bug: 1913195
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abe6a2af5625
Update dedicated search button paddings to match UX spec. r=mak,desktop-theme-reviewers,urlbar-reviewers

https://hg.mozilla.org/mozilla-central/rev/abe6a2af5625

Status: ASSIGNED → RESOLVED
Closed: 1 day ago
status-firefox132: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Blocks: 1914137
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: