1908922 - Layout of dedicated button has extra space and incorrect icon behaviour

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Josh Berman]

Attachment: Screenshot 2024-07-19 at 9.28.55 AM.png

Expected outcome:

1. In state when URL bar is focused, but dropdown is closed, the Dedicated search button is snug against left side of URL bar.

Actual outcome:

1. In state when URL bar is focused, but dropdown is closed, the Dedicated search button has a small gap between left side of URL bar.

Comment 1

[Dale Harvey (:daleharvey)]

Josh brought up several issues with the icons layout and behaviour and it isnt feasible to address them seperately so merging into one layout update

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1908922 - Update dedicated search button paddings to match UX spec. r=Mak

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1913202: S3

:daleharvey, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abe6a2af5625
Update dedicated search button paddings to match UX spec. r=mak,desktop-theme-reviewers,urlbar-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/abe6a2af5625

Comment 9

[Dana Lucaci, Desktop QA]

Hello,
I reproduced the issue with Firefox 130.0a1 (2024-07-19) on Windows 10. I tried to verify this issue with Firefox 132.0a1 (2024-09-23), but it seems that the expected result still does not meet the Figma requirements (which are: favicon 24px, icon 12px and a distance of 4px between them). The actual result at this point is: favicon 16px, icon 12px and a distance of 6px between them.
Is this still an issue, or is this the expected result after the fix?
Thank you!

Comment 10

[Josh Berman]

Hi Dana - Dale and I caught up offline and adjusted the mocks to facilitate a better experience. The mocks have a 16px favicon now. The spacing has been adjusted as well. This is the expected result now.

Figma link here

Thank you!

Comment 11

[Dale Harvey (:daleharvey)]

Cheers for answering Josh

Comment 12

[Dana Lucaci, Desktop QA]

Verified as fixed on Firefox Nightly 135.0a1 (20241218214439) on Windows 10, Ubuntu 22 and macOS 14.
Thank you!