1908934 - Whitespace around inline tags is not correctly preserved

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Greg Tatum [:gregtatum]]

https://www.bbc.com/travel/article/20240710-icelands-first-lady-takes-you-on-a-tour-of-her-super-chill-nation

Translating en-es with full page translation causes issues with whitespacing around inline tags. See the spacing around "Eliza Reid".

Before

But that's what happened after <a>Eliza Reid</a>, a Canadian graduate student at Oxford University, won a raffle for a date with a fellow student – future Icelandic President Guðni Jóhannesson.

After

Pero eso fue lo que pasó después de<a>Eliza Reid</a>, un estudiante de posgrado canadiense en la Universidad de Oxford, ganó una rifa por una cita con un compañero de estudios.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1908934 - Preserve whitespace around translated messages; r?#translations-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08e7ff2f73b5
Preserve whitespace around translated messages; r=translations-reviewers,nordzilla

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc @ translations/tests/browser/browser_translations_select_panel_copy_button.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ce2af902a88130666b6407b32d693fa81085c57b

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/translations/tests/browser/browser_translations_select_panel_copy_button.js | Test timed out

Comment 4

[Erik Nordin [:nordzilla]]

Hmm, I wouldn't expect this. Odd that the failure is "timed out".

I'm happy to take a look at this since I wrote this test and have a higher context here.

Shifting the NI to me.

Comment 5

[Erik Nordin [:nordzilla]]

Investigated and requested changes in Phabricator.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a37b448a56a
Preserve whitespace around translated messages; r=translations-reviewers,nordzilla

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4a37b448a56a