1908969 - Add some tests to ensure mozPrintCallback doesn't produce fuzzy/rasterized text

Status: RESOLVED FIXED

(Core :: Printing: Output, task)

Description

[Daniel Holbert [:dholbert]]

I'm filing this bug to write/land some regression tests for bug 1908587, as discussed in bug 1908587 comment 22.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1908969 part 1: Add some rendering tests for mozPrintCallback. r?#layout

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1908969 part 2: Add some rendering tests for mozPrintCallback, with scale applied. r?#layout

These tests fail if we incorrectly flatten to rasterized output when printing.
In particular, they fail on macOS, in the absense of the patches that recently
landed on bug 1908587.

Comment 3

[Daniel Holbert [:dholbert]]

Try run, based on mozilla-central from before bug 1908587 landed (which means the -002 test variants are expected to fail on macOS):
https://treeherder.mozilla.org/jobs?repo=try&revision=e643cea3f989f534ff73e1782d80df93eff08d8c

Comment 4

[Daniel Holbert [:dholbert]]

Try run based on mozilla-central from after bug 1908587 landed (so all tests are expected to pass):
https://treeherder.mozilla.org/jobs?repo=try&revision=2cc1a9c4c37253da67f7a0b575de278008be899c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af55593c47e8
part 1: Add some rendering tests for mozPrintCallback. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/3ac519b2219c
part 2: Add some rendering tests for mozPrintCallback, with scale applied. r=layout-reviewers,jfkthame

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/af55593c47e8
https://hg.mozilla.org/mozilla-central/rev/3ac519b2219c

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: Bug 1908969 part 1: Add some rendering tests for mozPrintCallback. r?#layout

Original Revision: https://phabricator.services.mozilla.com/D217153

Comment 8

[Daniel Holbert [:dholbert]]

Attachment: Bug 1908969 part 2: Add some rendering tests for mozPrintCallback, with scale applied. r?#layout

These tests fail if we incorrectly flatten to rasterized output when printing.
In particular, they fail on macOS, in the absense of the patches that recently
landed on bug 1908587.

Original Revision: https://phabricator.services.mozilla.com/D217154

Comment 9

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: None; this patch is not part of the build. However, there's a second-order "user impact if declined": we're trying to get Google Docs native print dialog support enabled on Google's end -- starting with current release 129, ideally -- and this patch-stack has tests for a relevant bug that we fixed in v129, but we didn't uplift the tests to 129 (yet). It would help ease the relevant Google engineers' minds about potentially enabling this feature in 129 if we uplifted these automated tests, to confirm that the bug is indeed (still) fixed in the 129 release train.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: zero
• Explanation of risk level: test-only
• String changes made/needed: None
• Is Android affected?: yes

Comment 10

[Daniel Holbert [:dholbert]]

(In reply to Phabricator Automation from comment #9)

release Uplift Approval Request

• User impact if declined: None; this patch is not part of the build. However, there's a second-order "user impact if declined": we're trying to get Google Docs native print dialog support enabled on Google's end

(for reference, see meta bug 1521655 for this project)

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e5acfc76aba3
https://hg.mozilla.org/releases/mozilla-release/rev/9a56b747aa5f