Closed Bug 1908999 Opened 3 months ago Closed 3 months ago

Sticky description text in Android Full Page Translations Global Settings

Categories

(Fenix :: Translations, enhancement, P3)

All
Android
enhancement

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: Dasha, Assigned: olivia)

References

Details

(Whiteboard: [fxdroid][foundation][translations:130])

Attachments

(2 files)

Attached image image.png

Steps to reproduce

  1. In Firefox Nightly 130 go to global settings.
  2. Under the "Translation settings section" click on either "Download languages" or "Automatic translation"
  3. Scroll on the page and observe how the description text under the title area is sticky for both pages.

Expected behavior

Only the titles like "Automatic translation" and "Download languages" should stay sticky, while other elements should scroll.

Actual behavior

The description text under the title area is sticky for both pages. This is inconsistent with the design of other areas and is surprising as there is no visual affordance to let the user know that this will be sticky.

Device information

Firefox version: 130.0a1 (Build #2016033063)
Android device model: Galaxy S21 5G (SM-G991W)
Android OS version: 12

Any additional information?

https://www.figma.com/design/GT6oZLFw32LiCwKl5GOMWD/Full-Page-Translation?node-id=14269-42636&t=UfleeXiQgxBkuFJP-4

Flags: needinfo?(ohall)
Flags: needinfo?(ohall)
Whiteboard: [fxdroid][foundation][translations:130]

Additionally looks like "Never Translate these sites" is impacted, so unsticky there too.

This patch changes a few sticky headers to regular items in the Android
global settings area.

The following areas info headers are now not sticky:

  • "Automatic translation"
  • "Never translate these sites"
  • "Download languages"

Design: https://www.figma.com/design/GT6oZLFw32LiCwKl5GOMWD/Full-Page-Translation?node-id=14269-42636&t=lHH09rMEOXzFDR5X-0

Assignee: nobody → ohall
Status: NEW → ASSIGNED
Pushed by ohall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8399773eaf45 Sticky description text in Android Full Page Translations Global Settings r=android-reviewers,gl
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: