1909012 - Update irregexp to new version 9b9d02b07c231de5046a87ac80d4bbe24a737097 from 2024-07-26 00:00:00

Status: RESOLVED DUPLICATE of bug 1910536

(Core :: JavaScript Engine, enhancement)

Description

[Update Bot]

This update covers 1330 commits, including 133 new upstream commits I've never filed a bug on before. (They're the top 133.). Here are the overall diff statistics.

---

js/src/irregexp/imported/regexp-ast.h | 15 +-
js/src/irregexp/imported/regexp-bytecode-peephole.cc | 2 +-
js/src/irregexp/imported/regexp-bytecode-peephole.h | 2 +-
js/src/irregexp/imported/regexp-compiler-tonode.cc | 11 +-
js/src/irregexp/imported/regexp-compiler.cc | 219 ++++++++-----
js/src/irregexp/imported/regexp-compiler.h | 2 +-
js/src/irregexp/imported/regexp-interpreter.cc | 19 +-
js/src/irregexp/imported/regexp-interpreter.h | 9 +-
js/src/irregexp/imported/regexp-macro-assembler-tracer.cc | 16 +-
js/src/irregexp/imported/regexp-macro-assembler.cc | 27 +-
js/src/irregexp/imported/regexp-macro-assembler.h | 5 +-
js/src/irregexp/imported/regexp-nodes.h | 19 +-
js/src/irregexp/imported/regexp-parser.cc | 28 +-
js/src/irregexp/imported/regexp-parser.h | 3 +-
js/src/irregexp/imported/regexp.h | 19 +-
js/src/irregexp/moz.yaml | 4 +-
16 files changed, 225 insertions(+), 175 deletions(-)

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=50742e7588471ae6d8d9eaba86c1814bea1fb729

Comment 3

[Update Bot]

Attachment: Bug 1909012 - Update irregexp to 9b9d02b07c231de5046a87ac80d4bbe24a737097

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• spidermonkey-sm-plain-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: agSovlO3RKCpe0dosm4U5Q, d_ZaMLk7QOKZnfZ0bGYRLw, WG_UzO_0TvajJNq73d-wAA, XpzZejLfTbaF_OZAnYQAKA)
• spidermonkey-sm-package-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: bOwkELM_TrafULiRJOsg9w, aUpoidL5T4iGeDzn9Ici_A, U-mvotStSdihOw-8YvdMJw, VHUdG8nPR1OSzitOqSEAgQ)
• spidermonkey-sm-pbl-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: BUV4d8COS4SZFoph0qBZuA, B42KCz4CRBC1rM2fvAhyUg, b6pEwMk7SmyP281rIHMCxA, M2hREnDXTtWUzSJPCn_A2w)
• spidermonkey-sm-pbl-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: C733_uS7QO6iYO-xYK0jBw, cI3jdScvTzCQE5J2t22Kjw, I8M5sxCsQyeZlKG3e7vMdg, PTgrswRDT5qDEHOVfNBorQ)
• hazard-linux64-shell-haz/debug - 4 of 4 failed on the same (retriggered) task (failed: BVfF8bOrQqO7TZndQJi4uA, ASAFmr4USA-QqEhKuFTYDQ, OthEE206TcC3YbznwWcVnQ, QYeDjP51QPmrN8V9fOisSg)
• spidermonkey-sm-arm-sim-linux32/debug - 4 of 4 failed on the same (retriggered) task (failed: Cm4KQZgwTmiuxGa_HdTMaQ, AyD7QnqZQ2KeQ1U7Cz1HJw, b2Fn5YDGTOKoxRhFwK8wYA, WWqgcPnuRLu5yqenHK5ftA)
• spidermonkey-sm-rt-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: cwBeDfg8Rae3mzHw6ZmzAQ, eiuIKyM0QZ6LcUbRezW8Bg, H3Hs869ySu6Lxa3afWdSGw, MnBjXTdTTMSuhscNO9tTfA)
• spidermonkey-sm-linux64-wasi/opt - 4 of 4 failed on the same (retriggered) task (failed: E8peZ2h0TfKoD36HpvsmPA, ItACE_0rQbiLFkN2gwkhhw, Q3A0To2_ShS_9JDpsKgP9g, XlUfLSbdRo2pg8R_Rrwo6A)
• spidermonkey-sm-asan-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: EVMU16XBR9mILBulEgoL2w, GEDagtXtSJyALFadVCT2nA, LX5I3ycwSiaDtT5v2PXMhg, O0CSIhKVRCKg-bLYg0YdTA)
• spidermonkey-sm-tsan-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: FmcM9VxoQnSOO4C32RhkVA, a_czOomoQYKyo8Pz2IKDVw, EL0xt2AMS2CDG_KMl7zI5A, H5rSJRUCSBGLnyHvXZrpcQ)
• spidermonkey-sm-fuzzilli-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: GnfcZDZHSOmmTK9yYQ0_eQ, AgVETM89S1GDKAI2lyRvTA, DkhT3cogSAixgPFoeUVM0g, S3ryt3bfQECcngz1TeLgGg)
• spidermonkey-sm-wasm-no-experimental-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: JRtESgWASzGLdzF2YcNvDw, KLHKW8ilTJSZCewc8g3v9Q, O4N9Eh3xSea5r6e62GHzQw, Ul5y51XWSdS3mlIH4Lx73Q)
• spidermonkey-sm-gdb-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: LsZRRhjvTH2qff_G7HgPVA, ahXz5BOBTo-pyeaOYXS68A, FduZd7PtT1uPrLrNd5r90w, JyaZWpRNRcK8fl9FAzG-YQ)
• spidermonkey-sm-compacting-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: M4vu34PlQb6fnFg0jXzBkA, CtMVmjx_SIeSbUHVE22ubw, J1jSRfM3QqWrc3qJaaBsOw, MGQRK83XR22for4y-m0lpw)
• spidermonkey-sm-linux64-wasi-intl/opt - 4 of 4 failed on the same (retriggered) task (failed: OGKiKFKGQS-WjXawaDiRmg, c0UouN3_Q_avrJGMWmVStg, NE-RVNlpTJO52wj-OXDxzw, QpO8xwaYQxaAnG31F926Eg)
• spidermonkey-sm-nonunified-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: RUX7tzDFT1i2Drc-X6qD_g, DHc0QV39RZiNzVvRi7EZBw, fwPTAMUFQtO92MEGkmt2xA, WRaIwHIoQ5WgSqoBmTyUZA)
• spidermonkey-sm-fuzzing-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: S3yeElXkT3qdvkbbIXwn2g, E2l6RGvJRDOt9-kyXlRW8w, evNSydANRiy5--tTBFfCQg, U8rRT73KQ2G1e7kT6pFGzA)
• spidermonkey-sm-linux64-wasi-pbl/opt - 4 of 4 failed on the same (retriggered) task (failed: TrzLJO_rSQq9c26HK_HxIw, aTDr_I6xTWasY2oLT8K6Vw, ehrkJhDaRhqdbzZVOt-2IA, HcWs_Ya9T2C14SeFszuf2g)
• spidermonkey-sm-arm64-sim-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: UgK4RYYCQKyZCirmFsfJwQ, PF8JjsYRQWWS8WKXUf9-vA, QZXgPurnTNSAB3LgBOGfNQ, UtpOb8f3Rv-0dAneULhvcA)
• spidermonkey-sm-rootanalysis-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: UJ9mjbm9RmmsZl4Ok0H1aQ, deM_QvBXT0iRc8zuVG7U8A, IcvsUKPnQ0ebUBHZfQD-ww, QYtsfU3-SdWM5z_F3_pLMw)
• spidermonkey-sm-nojit-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: X7TOLhLaR4qV2SJ9wrZssg, Fk1LvBIBSMCoQTOShpRKkQ, KIGv3RvtTzmY84QukKppLg, T5VWHPdjQdKKi4ylVsrhMQ)
• spidermonkey-sm-temporal-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: ZJd2p-2qTIa2la_tY1o4yA, cjrmB324SE6Lw4WivpfiFA, E8btb0F6RJy7dhqKd6jbzw, euvo873aQGSVUJ2awxaG2w)
• spidermonkey-sm-plain-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: S_Nr-0_aRgi6KsTbeRNLyQ, bkWfi8tRQnayyEdwt_RPzA, cs1GA-6LSn6KWHj2s1C14g, Syo3tpJPRu2f-1-6Jvx1TQ)
• spidermonkey-sm-plain-linux32/debug - 4 of 4 failed on the same (retriggered) task (failed: S7E7KDfaRI65HvHxCELBQg, cLwBJCHyR8-5YdZACGtZ4A, GG4NuvNqSKSJxpr649SMpA, WxzeLp96RpeDn1VuemWpMQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor js/src/irregexp/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1909012 - Add definitions for DirectHandle and Cast; r=iain!

Comment 6

[Dan Minor [:dminor]]

Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=d4f20a88676ae8275bbdc8d0fe4664761a73d25f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4c28d48ada
Update irregexp to 9b9d02b07c231de5046a87ac80d4bbe24a737097 r=iain
https://hg.mozilla.org/integration/autoland/rev/1372a6ecb8e2
Add definitions for DirectHandle and Cast; r=iain

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9d4c28d48ada
https://hg.mozilla.org/mozilla-central/rev/1372a6ecb8e2

Comment 9

[Sandor Molnar[:smolnar]]

Backout for causing irregexp update.

Backout link: https://hg.mozilla.org/integration/autoland/rev/12fb801edc2f15226ab8221c8e0be69a0adc5ce7

Comment 10

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Comment 11

[Florin Bilt]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4c28d48ada
Update irregexp to 9b9d02b07c231de5046a87ac80d4bbe24a737097 r=iain
https://hg.mozilla.org/integration/autoland/rev/1372a6ecb8e2
Add definitions for DirectHandle and Cast; r=iain

Perfherder has detected a browsertime performance change from push 1372a6ecb8e2687a96fe48c485daa08bf17cf130.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
6%	fandom loadtime	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	187.59 -> 176.44	Before/After
5%	fandom loadtime	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	186.17 -> 176.59	Before/After
3%	fandom SpeedIndex	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	193.63 -> 187.69	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1571

For more information on performance sheriffing please see our FAQ.

Comment 12

[Florin Bilt]

(In reply to Sandor Molnar[:smolnar] from comment #9)

Backout for causing irregexp update.

Backout link: https://hg.mozilla.org/integration/autoland/rev/12fb801edc2f15226ab8221c8e0be69a0adc5ce7

Perfherder has detected a browsertime performance change from push ce2af902a88130666b6407b32d693fa81085c57b.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
6%	fandom loadtime	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	176.62 -> 187.29	Before/After
5%	fandom loadtime	linux1804-64-shippable-qr	fission warm webrender	254.48 -> 266.26	Before/After
4%	fandom loadtime	macosx1015-64-shippable-qr	bytecode-cached fission warm webrender	133.88 -> 139.73	Before/After
4%	fandom LastVisualChange	linux1804-64-shippable-qr	fission warm webrender	381.83 -> 398.23	Before/After
4%	fandom loadtime	macosx1015-64-shippable-qr	bytecode-cached fission warm webrender	134.07 -> 139.24	Before/After
3%	cnn-nav.world fcp	linux1804-64-shippable-qr	cold fission webrender	479.01 -> 493.88	Before/After
2%	fandom PerceptualSpeedIndex	linux1804-64-shippable-qr	fission warm webrender	220.67 -> 225.40	Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1593

For more information on performance sheriffing please see our FAQ.