1909035 - Update PDF.js to new version ed83d7c5e16798a56c493d56aaa8200dd280bb17 from 2024-07-19 21:08:50

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 7 commits. Here are the overall diff statistics, and then the commit information.

---

taskcluster/kinds/fetch/toolchains.yml | 2 +-
toolkit/components/pdfjs/content/build/pdf.mjs | 31 ++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 15 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 103 ++++++++++---
toolkit/components/pdfjs/content/web/viewer.mjs | 92 +++++++++---
toolkit/components/pdfjs/moz.yaml | 4 +-
7 files changed, 180 insertions(+), 71 deletions(-)

---

b71fa727e16bb24c6260510dc4117e3b7ca46590 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/b71fa727e16bb24c6260510dc4117e3b7ca46590
Authored: 2024-07-19 17:57:53 +0200
Committed: 2024-07-19 21:57:46 +0200

Load the image-to-text model when opening the pdf viewer in Firefox (bug 1908938)

Files Modified:

• src/display/editor/stamp.js
• src/display/editor/tools.js
• web/app.js
• web/firefoxcom.js
• web/genericcom.js

---

5946d20dc984a801648ccd9fbb334d9560b9e6c2 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/5946d20dc984a801648ccd9fbb334d9560b9e6c2
Authored: 2024-07-18 15:12:35 +0200
Committed: 2024-07-18 15:12:39 +0200

[Editor] Allow to change a preference from the editor UI manager

We want to be able to update a global pref (i.e. enableAltText) in using a toggle button in the new alt-text dialog.

Files Modified:

• src/display/editor/tools.js
• web/app.js

---

d24a61c648fc79ce0b87137266562c8dc04e841c by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/d24a61c648fc79ce0b87137266562c8dc04e841c
Authored: 2024-07-18 12:33:29 +0200
Committed: 2024-07-18 13:29:32 +0200

Allow /XYZ destinations without zoom parameter (issue 18408)

According to the PDF specification these destinations should have a zoom parameter, which may however be null, but it shouldn't be omitted; please see https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2095870

Hence we try to work-around bad PDF generators by making the zoom parameter optional when validating explicit destinations in both the worker and the viewer.

Files Added:

• test/pdfs/issue18408_reduced.pdf

Files Modified:

• src/core/catalog.js
• test/pdfs/.gitignore
• test/unit/api_spec.js
• web/pdf_link_service.js

---

6cc32b699f79a35505659351fb04a5c8e7bac3fa by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/6cc32b699f79a35505659351fb04a5c8e7bac3fa
Authored: 2024-07-17 19:51:53 +0200
Committed: 2024-07-18 09:52:10 +0200

Add the possibility to change some pdfjs preferences from the viewer (bug 1908483)

Files Modified:

• web/firefoxcom.js
• web/preferences.js

---

99f34f4c2edbd64a6fc39fc57b3ca26995281589 by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/99f34f4c2edbd64a6fc39fc57b3ca26995281589
Authored: 2024-07-12 07:46:05 +0200
Committed: 2024-07-17 16:57:55 +0200

Include additional data when fetching browser preferences in the PDF Viewer (bug 1908401)

To avoid having to request and await various browser data early during the PDF Viewer initialization, we can include that data in the existing preference fetching instead. With other planned changes to the PDF Viewer, the current situation would only become worse over time.

Note: Technically this data aren't preference-values, however we're already including other non-prefs in this list (e.g. isInAutomation) and doing it this way simplifies the overall implementation.

Files Modified:

• web/app.js
• web/app_options.js
• web/external_services.js
• web/firefoxcom.js

---

37db3a7143827427711cafc15dd9f8cab05cd38f by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/37db3a7143827427711cafc15dd9f8cab05cd38f
Authored: 2024-07-17 14:08:54 +0200
Committed: 2024-07-17 14:20:50 +0200

Remove active smask when restoring the initial canvas state

Fixes #18444.

Files Added:

• test/pdfs/issue18444.pdf.link

Files Modified:

• src/display/canvas.js
• test/test_manifest.json

---

8a979c2d0e37d3fb398fb1af90953998b1f89381 by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/8a979c2d0e37d3fb398fb1af90953998b1f89381
Authored: 2024-07-16 13:08:26 +0200
Committed: 2024-07-16 13:08:26 +0200

[api-minor] Remove Outliner from the official API

As far as I can tell Outliner is only exposed in the API because we need to access it when running some of the reference-tests, but is otherwise not used.
Hence this seems like something that should be kept internal and thus only exposed in TESTING-builds.

Files Modified:

• src/pdf.js
• test/driver.js
• test/unit/pdf_spec.js
• web/pdfjs.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=f99181919de2658c02fbd3da07aca44db7565c3e

Comment 2

[Update Bot]

Attachment: Bug 1909035 - Update PDF.js to ed83d7c5e16798a56c493d56aaa8200dd280bb17 r=#pdfjs-reviewers

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a5eaa31ff38
Update PDF.js to ed83d7c5e16798a56c493d56aaa8200dd280bb17 r=pdfjs-reviewers,Snuffleupagus

Comment 5

[Atila Butkovits]

Backed out for causing pdf paint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/62fe7f34b55b1474878c7921b5e4e72988b928c1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=aYWOiWcER46ohczAnSOgVg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=33666aa99427b377e6bda6865a71b441063b2a3a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=467259404&repo=autoland&lineNumber=1379

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/422e53e14bb4
Update PDF.js to ed83d7c5e16798a56c493d56aaa8200dd280bb17 r=pdfjs-reviewers,Snuffleupagus

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/422e53e14bb4