Closed Bug 1909063 Opened 3 months ago Closed 2 months ago

[RTL][Toolbar redesign] Navigation arrows flipped for RTL

Categories

(Fenix :: Toolbar, defect, P2)

All
Android
defect

Tracking

(firefox128 disabled, firefox129 disabled, firefox130 disabled, firefox131 fixed)

RESOLVED FIXED
131 Branch
Tracking Status
firefox128 --- disabled
firefox129 --- disabled
firefox130 --- disabled
firefox131 --- fixed

People

(Reporter: itiel_yn8, Assigned: skhan, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kitkat banana sprint])

Attachments

(6 files)

Attached image Main navigation arrows
No description provided.
Attachment #9413981 - Attachment description: Back navigation arrow in the site details dilog → Back navigation arrow in the site details dialog

Thanks for reporting this bug. The screenshots were helpful for highlighting the problem. Our UX designer will review the toolbar design with the localization team.

Is this a new bug in Firefox Nightly? Or has this been a problem for a long time?

Assignee: nobody → apandya

Kind of new. First seen by Amiad (CC'd in this bug) since May 24th.

I asked on the localization channel on company slack, but they asked me to check with you (Itiel) about this.
Would it be okay if we keep the nav bar design the same for both LTR and RTL languages?
i.e. < , > , + , Tabs , menu

or do you think it should be
Menu , tabs , + , < , > ?

Flags: needinfo?(itiel_yn8)

(In reply to Aarjav [:aarjav] from comment #6)

I asked on the localization channel on company slack, but they asked me to check with you (Itiel) about this.
Would it be okay if we keep the nav bar design the same for both LTR and RTL languages?
i.e. < , > , + , Tabs , menu

or do you think it should be
Menu , tabs , + , < , > ?

The latter.

Flags: needinfo?(itiel_yn8)

Thank you! We will keep the nav bar order for RTL languages as
Menu , tabs , + , < , >.

Flags: needinfo?(royang)
Flags: needinfo?(cpeterson)
Flags: needinfo?(royang)
Summary: [RTL] Navigation arrows flipped for RTL → [RTL][Toolbar redesign] Navigation arrows flipped for RTL
Flags: needinfo?(cpeterson)
Severity: -- → S3
Priority: -- → P2
Whiteboard: [kitkat banana sprint]
Assignee: apandya → skhan
Status: NEW → ASSIGNED
See Also: → 1915324
Blocks: 1915324
See Also: 1915324

Does not block Bug 1915324 anymore, that is handled separately

No longer blocks: 1915324
See Also: → 1915438

I've been fixing back/forward arrows in a few screens for RTL mentioned in this and related bugs. However, these icons are used throughout the app and I am hoping if anything they fix more screens rather than break down any.
Requesting QA testing for the same.

Flags: qe-verify+
See Also: → 1915324
Attached image RTLvsnonRTL.png

Verified on the latest Fenix Nightly 131.0a1 from 8/29 with a Google Pixel 6 (Android 15), on Arabic.
The differences are:

  • the navigation buttons in RTL are > and <, versus non RTL < and >;
  • the ETP panel's arrows in RTL <, versus non RTL >.

I've attached screenshots in RTL language vs non RTL for better vizualization.
I'll remove the qe-verify+ flag for now,

Flags: qe-verify+
Flags: needinfo?(skhan)
Pushed by sarahkhan1107@hotmail.com: https://hg.mozilla.org/integration/autoland/rev/594a6561b636 Fix flipped arrows on navigation bar for RTL r=android-reviewers,tchoh,petru
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: