1909063 - [RTL][Toolbar redesign] Navigation arrows flipped for RTL

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Itiel]

Attachment: Main navigation arrows

Comment 1

[Itiel]

Attachment: Back navigation arrow in the site details dialog

Comment 2

[Chris Peterson [:cpeterson]]

Thanks for reporting this bug. The screenshots were helpful for highlighting the problem. Our UX designer will review the toolbar design with the localization team.

Is this a new bug in Firefox Nightly? Or has this been a problem for a long time?

Comment 3

[Itiel]

Kind of new. First seen by Amiad (CC'd in this bug) since May 24th.

Comment 4

[Itiel]

Attachment: Extensions arrow in the main menu

Comment 5

[Itiel]

Attachment: Back arrow inside the Extensions menu

Comment 6

[Aarjav [:aarjav]]

I asked on the localization channel on company slack, but they asked me to check with you (Itiel) about this.
Would it be okay if we keep the nav bar design the same for both LTR and RTL languages?
i.e. < , > , + , Tabs , menu

or do you think it should be
Menu , tabs , + , < , > ?

Comment 7

[Itiel]

(In reply to Aarjav [:aarjav] from comment #6)

I asked on the localization channel on company slack, but they asked me to check with you (Itiel) about this.
Would it be okay if we keep the nav bar design the same for both LTR and RTL languages?
i.e. < , > , + , Tabs , menu

or do you think it should be
Menu , tabs , + , < , > ?

The latter.

Comment 8

[Aarjav [:aarjav]]

Thank you! We will keep the nav bar order for RTL languages as
Menu , tabs , + , < , >.

Comment 9

[[:skhan]]

Attachment: Bug 1909063 - Fix flipped arrows on navigation bar for RTL

Comment 10

[[:skhan]]

Does not block Bug 1915324 anymore, that is handled separately

Comment 11

[[:skhan]]

I've been fixing back/forward arrows in a few screens for RTL mentioned in this and related bugs. However, these icons are used throughout the app and I am hoping if anything they fix more screens rather than break down any.
Requesting QA testing for the same.

Comment 12

[miralobontiu]

Attachment: RTLvsnonRTL.png

Verified on the latest Fenix Nightly 131.0a1 from 8/29 with a Google Pixel 6 (Android 15), on Arabic.
The differences are:

• the navigation buttons in RTL are > and <, versus non RTL < and >;
• the ETP panel's arrows in RTL <, versus non RTL >.

I've attached screenshots in RTL language vs non RTL for better vizualization.
I'll remove the qe-verify+ flag for now,

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/594a6561b636
Fix flipped arrows on navigation bar for RTL r=android-reviewers,tchoh,petru

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/594a6561b636