1909192 - Crash if sharing tabs fail and having a new share sheet open

Status: NEW

(Firefox for Android :: Toolbar, defect, P3)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: CrashIfCannotShareTabs.mp4

Steps to reproduce

1. Be authenticated in your Mozilla account and have other devices to which you can share tabs to
2. After starting the application disable the internet connection
3. Try sharing any tab to one of your other devices
4. Close the current share sheet
5. Open a new share sheet (this is the most important step)
6. Wait until the timeout for the failed sharing of tabs

Expected behavior

See a snackbar informing about sharing failed with an option to retry

Actual behavior

Crash

Any additional information?

efa68afa-ed8b-43fd-aba8-9740419250c8
java.lang.IllegalStateException: Fragment ShareFragment{8eb9b9a} (11d3d763-3b05-424c-8e8d-715643b142e7) not attached to a context.

---

java.lang.IllegalStateException: Fragment ShareFragment{8eb9b9a} (11d3d763-3b05-424c-8e8d-715643b142e7) not attached to a context.
at androidx.fragment.app.Fragment.requireContext(Fragment.java:18)
at org.mozilla.fenix.ext.FragmentKt.getRequireComponents(Fragment.kt:6)
at org.mozilla.fenix.share.ShareFragment.consumePrompt(ShareFragment.kt:1)
at org.mozilla.fenix.share.ShareFragment$onCreateView$1.invoke(ShareFragment.kt:15)
at org.mozilla.fenix.share.DefaultShareController$shareToDevicesWithRetry$1.invokeSuspend(ShareController.kt:177)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:111)
at android.os.Handler.handleCallback(Handler.java:959)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8592)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@d07d665, Dispatchers.Main]

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Setting S3/P3 since the bug existed for a long time and nobody else reported -> it's really an edgecase.