1909409 - Implement an SQLite-backed `nsIKeyValueService`

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task)

Description

[Lina Butler [:lina]]

This bug covers landing an implementation of nsIKeyValueService, behind a new contract ID, that uses SQLite instead of rkv for persistence. It should pass all the tests for our current implementation. Once we have it in the tree, we can start migrating callers to use it, but that migration is out of scope for this bug.

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1909409 - Canonicalize paths in `nsIKeyValueService`. r?nika!

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1909409 - Upgrade `kvstore` to Rust 2021. r?nika!

Depends on D217386

Comment 3

[Lina Butler [:lina]]

Attachment: Bug 1909409 - Implement an SQLite-backed `nsIKeyValueService`. r=nika!,mak,beth,janerik

Depends on D217387

Comment 4

[Lina Butler [:lina]]

Attachment: Bug 1909409 - Expose the new SQLite-backed `nsIKeyValueService` to chrome JS callers. r=mak!,nika!,beth,janerik

Depends on D217388

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9dc6c190bdf
Canonicalize paths in `nsIKeyValueService`. r=nika,media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/28c453c5e221
Upgrade `kvstore` to Rust 2021. r=nika
https://hg.mozilla.org/integration/autoland/rev/5fee953eeba3
Implement an SQLite-backed `nsIKeyValueService`. r=nika
https://hg.mozilla.org/integration/autoland/rev/882fc6b731f4
Expose the new SQLite-backed `nsIKeyValueService` to chrome JS callers. r=mak,nika

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/7c116e941f9a22051b8714f871d3b9adcc298899

Push with failures

Failure log -> error[E0432]: unresolved import std::num::NonZero

Comment 7

[Lina Butler [:lina]]

Hmm, it's weird that it didn't fail on Try: https://treeherder.mozilla.org/jobs?repo=try&revision=7ebd5908f639c27817f7b4b10c8b6c14a4d45288 I wonder if Try was using a different Rust toolchain?

std::num::NonZero was introduced in Rust 1.79.0, and our MSRV is 1.76.0, so that's definitely on me (sorry!)—but I am still curious why it didn't fail earlier!

Comment 8

[Sandor Molnar[:smolnar]]

(In reply to Lina Butler [:lina] from comment #7)

Hmm, it's weird that it didn't fail on Try: https://treeherder.mozilla.org/jobs?repo=try&revision=7ebd5908f639c27817f7b4b10c8b6c14a4d45288 I wonder if Try was using a different Rust toolchain?

std::num::NonZero was introduced in Rust 1.79.0, and our MSRV is 1.76.0, so that's definitely on me (sorry!)—but I am still curious why it didn't fail earlier!

Looking at your Try push, the two jobs that failed on autoland, didn't run on your Try run.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/694080c9ab1b
Canonicalize paths in `nsIKeyValueService`. r=nika,media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/50130de77981
Upgrade `kvstore` to Rust 2021. r=nika
https://hg.mozilla.org/integration/autoland/rev/6539306bb3fd
Implement an SQLite-backed `nsIKeyValueService`. r=nika
https://hg.mozilla.org/integration/autoland/rev/11fbdbd02d5b
Expose the new SQLite-backed `nsIKeyValueService` to chrome JS callers. r=mak,nika

Comment 10

[Lina Butler [:lina]]

(In reply to Sandor Molnar[:smolnar] from comment #8)

Looking at your Try push, the two jobs that failed on autoland, didn't run on your Try run.

I missed that 😬 Thanks! Should be all fixed up now 🤞

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/694080c9ab1b
https://hg.mozilla.org/mozilla-central/rev/50130de77981
https://hg.mozilla.org/mozilla-central/rev/6539306bb3fd
https://hg.mozilla.org/mozilla-central/rev/11fbdbd02d5b