1909455 - Returned value of "unhandledPromptBehavior" for "session.new" has an invalid value "dismiss and notify" when unspecified

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[dariokondratiuk]

Steps to reproduce:

Called the session.new with the arguments

{"id":1,"method":"session.new","params":{"capabilities":{"alwaysMatch":{"acceptInsecureCerts":false,"webSocketUrl":true}}}}

Actual results:

I got the response

{"type":"success","id":1,"result":{"sessionId":"4baa79eb-cbfc-4eec-8a8b-3a0b8561268a","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"130.0a1","platformName":"mac","unhandledPromptBehavior":"dismiss and notify","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0","moz:buildID":"20240722092846","moz:headless":false,"moz:platformVersion":"23.5.0","moz:processID":33451,"moz:profile":"/var/folders/_d/6zl2pzmn1cd0y9h9rdx6zwcc0000gn/T/qcmjvky2.bg4","moz:shutdownTimeout":60000,"proxy":{}}}

Expected results:

According to the docs https://w3c.github.io/webdriver-bidi/#type-session-UserPromptHandler, "dismiss and notify" is not a valid value

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sarah Clements [:sclements]]

I don't think this belongs here, moving it. Bad bot.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for the report! As it looks like this is a problem with the WebDriver BiDi specification especially when serializing the user prompt handler:
https://w3c.github.io/webdriver/#dfn-serialize-the-user-prompt-handler

When the capability hasn't been specified when requesting a new session we don't have any entry and the map is null, and in the serialization steps we just return dismiss and notify as first step. Most likely we should make that dependent on the BiDi flag to make it conforming to the CDDL.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Using an empty object as value for session.new we return that as well. Given that the capability is optional in the returned capabilities we might actually not include it at all?

Comment 5

[Julian Descottes [:jdescottes]]

In the scope of this bug, let's just stop returning the capability if it's not provided by the client.
We can file a follow up to handle the edge cases that still exist in the spec.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1909455 - [bidi] Do not return "unhandledPromptBehavior" capability when not provided by a client.

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1909455 - [wdspec] Update the tests for "session.new" command to not return "unhandledPromptBehavior" capability by default.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/228cec8e3476
[bidi] Do not return "unhandledPromptBehavior" capability when not provided by a client. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d3fca12d84b3
[wdspec] Update the tests for "session.new" command to not return "unhandledPromptBehavior" capability by default. r=webdriver-reviewers,jdescottes

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/228cec8e3476
https://hg.mozilla.org/mozilla-central/rev/d3fca12d84b3