190946 - refreshing newsgroups does not download all groups

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Olli Pettay [:smaug][[e-mail]]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030127
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030127

Refreshing newsgroups (news.helsinki.fi) does not show (or download?) all groups.
I just tested 1.2.1 too and it works ok.

(news.helsinki.fi has about 15 000 groups, but only some of
them shows up outside helsinki.fi-domain. So testing might be difficult.)

Reproducible: Always

Steps to Reproduce:

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

2003012408 -OK
2003012522 -Broken

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

2003012505 OK
2003012522 -Broken

I'm not sure what has regressed this.
Something in the netwerk?

CC'ing darin

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yes, this is a regression of bug 189672.
(Just tested with and without
http://bugzilla.mozilla.org/attachment.cgi?id=112576&action=view)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Trying to download the groups ->
"OnDataAvailable implementation consumed no data" (nsInputStreamPump.cpp:420)

I'm sorry for all this spamming...

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 190994 has been marked as a duplicate of this bug. ***

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Blocking 1.3b?

Comment 7

[Ninoschka Baca]

Trunk build 2003-01-28: In a new profile, I connect to news.mcom.com, go to the
Subscribe dialog and it is only showing newsgroups that begin with an "a" which
is a very limited number of groups. I would expect to see groups from "a" to
"z". I don't have to select refresh to see this problem.

Comment 8

[Darin Fisher]

i've just hit this problem while trying to debug bug 190988.  turns out that
inside ReadNewsList we are hitting:

  if (m_readNewsListCount == READ_NEWS_LIST_COUNT_MAX) {

  }

as a result we enter the NEWS_FINISHED state, and stay there until the timeout
fires.  however, necko is not told to suspend pushing data to news, and the next
OnDataAvailable event from necko is ignored by news.  this causes necko to abort
the socket connection, since we would otherwise end up in an infinite loop until
the timeout fires.  i'm not sure exactly how to work around this problem, but it
appears as if mailnews needs to be modified to properly put necko to sleep
during the timeout period.

Comment 9

[Darin Fisher]

Attachment: v1 patch

adds code to suspend/resume necko at the right time.  simple enough, but there
is a little bit of trickiness in ensuring that the final call to
ProcessProtocolState is made (after all of the news list has been downloaded).

Comment 10

[Darin Fisher]

-> me (upping severity.. this is got to be a beta blocker)

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 112917 [details] [diff] [review]
v1 patch

r/sr=sspitzer

Comment 12

[Darin Fisher]

Comment on attachment 112917 [details] [diff] [review]
v1 patch

seeking drivers approval for 1.3b... this is an important bug to fix.  low-risk
patch.	bug 176919 regression.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 112917 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 14

[Darin Fisher]

fixed-on-trunk

Comment 15

[esther]

verified using the same scenario nbaca used in comment 7.  verified with builds
20030228 on winxp, macosx, and linux